Closed Bug 1321639 Opened 8 years ago Closed 5 years ago

baldr: experimental text format: prettier printing of "first" nodes

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: sunfish, Unassigned)

References

Details

Baldr uses implicit "first" nodes in its AST representation of wasm to represent stack-machine code which doesn't otherwise fit the AST structure.

The experimental text format currently renders these as "first(x, y, z)" (which is a node that evaluates x, y, and z, and then returns the value of x). However, it may be easier to read if we printed them as a kind of "let" expression, something like "(let tmp = x; y; z; tmp)" or so.
Marking P3 for now. I don't know how fast we want this. If this should definitely get in in this release, please mark as P1. If the deadline is the next train, please mark P2.
Priority: -- → P3
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
We don't do text rendering of wasm modules in Gecko itself (the debugger does it for us now).
Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.