Closed
Bug 1321879
Opened 8 years ago
Closed 8 years ago
Get rid of IsCallerChrome usage in DOM animations code
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
2.45 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
13.36 KB,
patch
|
birtles
:
review+
|
Details | Diff | Splinter Review |
8.64 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8816557 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8816559 -
Flags: review?(bbirtles)
Updated•8 years ago
|
Attachment #8816557 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8816559 -
Flags: review?(bbirtles) → review+
Comment 3•8 years ago
|
||
Hello bz, could you please wait for landing patches of this bug until bug 1305325 is merged into inbound? I will land patches in bug 1305325 to autoland, one of the patches will conflict this part 2 patch on mozilla-central if you are going to land to inbound. This is the rebased patch of the part 2. I am sorry for the inconvenience.
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 4•8 years ago
|
||
I can do that, sure. Thank you for posting the merged patch!
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/29e59ce35d70 part 1. Add an API on GlobalObject to get the caller type, for use in things like WebIDL constructors. r=bholley https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c3a434a0b2 part 2. Stop using IsCallerChrome() in animations API. r=birtles
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/29e59ce35d70 https://hg.mozilla.org/mozilla-central/rev/c0c3a434a0b2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(bzbarsky)
You need to log in
before you can comment on or make changes to this bug.
Description
•