Closed Bug 1322026 Opened 8 years ago Closed 8 years ago

Address book: Edit > Search Addressed doesn't work on current trunk

Categories

(Thunderbird :: Address Book, defect)

Product:
Thunderbird
Component:
Address Book
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird52 fixed, thunderbird53 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 53.0
Tracking Flags:
Tracking Status
thunderbird52 --- fixed
thunderbird53 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

1322026-found-count-string.patch
1.68 KB, patch
aceman
: review+
jorgk-bmo
: approval-comm-aurora+
Details | Diff | Splinter Review 
Address book: Edit > Search Addressed doesn't work on current trunk

Console says:
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName] XStringBundle:22
  getString XStringBundle:22:22
  gSearchAbViewListener.onCountChanged chrome://messenger/content/ABSearchDialog.js:39:22
  SetAbView chrome://messenger/content/addressbook/abResultsPane.js:76:26
  onSearch chrome://messenger/content/ABSearchDialog.js:294:5
  onSearchButton chrome://messenger/content/ABSearchDialog.js:301:9
  oncommand chrome://messenger/content/ABSearchDialog.xul:1:1

Lovely, ABSearchDialog.js:39 still has:
  .get(aTotal, gAddressBookBundle.getString("matchesFoundCount"))
That string was retired in bug 1313950.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED

        Attachment #8816742 -
        Flags: review?(acelists)

    
    

    
  
No, bug 1313950 was fine, we forgot to change it in bug 1320570.
Blocks: 1320570
OS: Unspecified → All
Hardware: Unspecified → All

    
    

    
  
Comment on attachment 8816742 [details] [diff] [review]
1322026-found-count-string.patch

Review of attachment 8816742 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

        Attachment #8816742 -
        Flags: review?(acelists) → review+

    
    

    
  
https://hg.mozilla.org/comm-central/rev/59608977c7bd08fe89b336e382480f9285eff695
Landed with corrected commit message:
Bug 1322026 - Bug 1320570 follow-up: Fixed string name for plural form. r=aceman a=jorgk
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

    
    

    
  
Comment on attachment 8816742 [details] [diff] [review]
1322026-found-count-string.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1320570
Bug 1320570 is considered for uplift, so this one needs to go, too.

        Attachment #8816742 -
        Flags: approval-comm-aurora?

    
    

    
  
Comment on attachment 8816742 [details] [diff] [review]
1322026-found-count-string.patch

Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/a463541c03479c64a0a29601a25553b8d89d561a

        Attachment #8816742 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: