1322120 - Address bar items and select items are not highlighted properly

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

This bug started to appear about a week ago in Nightly (works in latest release). My current configuration: Linux Mint 18, Cinnamon 3.0.7, Firefox 53.0a1 (20161204030210).

When I hover any item in the address bar (with mouse cursor or arrow keys), or I select anything in the classification/product/component/... select on https://bugzilla.mozilla.org/query.cgi?format=advanced, the highlight style is not applied, or is not applied correctly. Seems the font color changes, but the "line" background is colored the same as non selected items.

Comment 1

[:Gijs (he/him)]

Can you please find a regression window with mozregression? ( https://mozilla.github.io/mozregression/ )

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi :Gijs.

I ended up with

> Error: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for 8f1e4206 was:
> Merge m-c to autoland on a CLOSED TREE. a=merge

Using mozregression I tested these builds:
- 2016-11-30 (13736e2db6eb94b02dd28cc88f2943b8109aa374) good
- 2016-12-02 (f65ad27efe839ce9df0283840a1a40b4bbc9ead0) bad
- 2016-12-01 (cd4cdcc9ad6c45dad8b8d8c0d40e459db2bca8a1) bad
- 2016-11-30 22:08:56.091000 (8f1e420699832d42753c6503aa31861be6f5b186) bad
- 2016-11-30 16:11:33.370000 (741a720c98cdb92c229376be0badbf036f653bff) good

Comment 3

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/pushloghtml?tochange=8f1e42069983&fromchange=741a720c98cdb92c229376be0badbf036f653bff

I suspect bug 1320860.

Michal, does this reproduce with:

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-linux64/1480528364/

and 

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-linux64/1480474861/

?

Also, any chance of a screenshot of the correct and broken behaviours?

Karl, any chance this regression was caused by bug 1320860 ?

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot-1480528364.png

1480528364 is broken.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot-1480474861.png

And 1480474861 still works.

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Unfortunately I was unable to take the screenshot of the address bar, as it disappears immediately the screenshot tool tries to take the shot. The same for the download button "bubble", where I noticed the progress bar looks like disappearing from the left instead of being colored with the download progress.

Comment 7

[Karl Tomlinson (:karlt)]

Thanks for the quick report and regression range.

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: bug 1322120 use text node for field and selected colors

This adjustment is required for changes to MOZ_GTK_TEXT_VIEW in a6aabcb07a6e.
MOZ_GTK_TEXT_VIEW_TEXT now retrieves the equivalent node from WidgetStyleCache.

Review commit: https://reviewboard.mozilla.org/r/97722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97722/

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Sure, I'll look at it. I wonder if we also can get the sMozFieldBackground from the text window beside the text colors.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

I have hard time to reproduce this. Michal, can you please provide exact Gtk version you use?

Comment 13

[Botond Ballo [:botond]]

(In reply to Martin Stránský from comment #12)
> I have hard time to reproduce this. Michal, can you please provide exact Gtk
> version you use?

I can also reproduce this, with GTK 3.14.5. I'm running on Debian stable with KDE.

Comment 14

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Hi Martin. I have 3.18.9-1ubuntu3.1.

Comment 15

[will69]

I am also seeing this. There is no selection background color in the address bar and in content. In addition, the bookmarks menu, the downloads drop down and the "burger" menu are all painted extremely slowly and without a background, i.e. transparent and without anti alias.

Last good revision: 741a720c98cdb92c229376be0badbf036f653bff
First bad revision: 8f1e420699832d42753c6503aa31861be6f5b186
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=741a720c98cdb92c229376be0badbf036f653bff&tochange=8f1e420699832d42753c6503aa31861be6f5b186

KDE 4.11.5 running on openSUSE 13.1

libgtk-2 is 2.24.23 (Clearlooks theme)
libgtk-3 is 3.10.9  (Default theme)

Should I file a new bug since this is somewhat different?

Comment 16

[will69]

I do get selection background color if I change both GTK2 and GTK3 theme to "Adwaita". The transparent drop down menus are not fixed, however.

Comment 17

[Botond Ballo [:botond]]

(In reply to will69 from comment #15)
> Pushlog:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=741a720c98cdb92c229376be0badbf036f653bff&tochange=8f1e
> 420699832d42753c6503aa31861be6f5b186
> 
> [...]
> 
> Should I file a new bug since this is somewhat different?

This regression range contains bug 1320860, the bug identified as being responsible for this bug. I would wait until this bug is fixed, since chances are the fix will fix your issue too.

Comment 18

[will69]

Installing "gtk3-engine-oxygen" and "gtk3-theme-oxygen" and switching both GTK2 and GTK3 themes to "oxygen-gtk" solved the transparent dropdown menu problem. (Switching themes back to "Adwaita" still reproduces the problem.) Highlighting works. Tooltips are black-on-almost-black now, though. Sigh!

Comment 19

[Botond Ballo [:botond]]

[Tracking Requested - why for this release]:
We should not ship 53 with this regression.

Comment 21

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8817466 [details]
bug 1322120 use text node for field and selected colors

https://reviewboard.mozilla.org/r/97722/#review98128

Yes, that reflects the gtk code:

https://git.gnome.org/browse/gtk+/tree/gtk/gtktextview.c?h=gtk-3-18#n5792
https://git.gnome.org/browse/gtk+/tree/gtk/gtktextview.c?h=gtk-3-18#n7775

Comment 22

[Marcia Knous [:marcia]]

Tracking 53+ so we don't ship with this regression.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c2cedbdeb65
use text node for field and selected colors r=stransky+263117

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6c2cedbdeb65

Comment 25

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Works for me in build 20161217030205 again.

Comment 26

[will69]

WFM with KDE 4.11.5 (with libgtk 3.10.9) using "oxygen-gtk" and "Adwaita". Thanks a lot!

Comment 27

[Dão Gottwald [:dao]]

Backed out for causing a worse regression, bug 1324262.

https://hg.mozilla.org/integration/mozilla-inbound/rev/12f4a1387fbc20a4696cd0cc9ea1ae7cddeb213c

Comment 29

[Karl Tomlinson (:karlt)]

Backed out a6aabcb07a6e from bug 1320860 until bug 1324262 is addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0b87b3bc2dcfe0561f05d7ac780b023ea54ac23

Comment 30

[Karl Tomlinson (:karlt)]

Fixed by https://hg.mozilla.org/mozilla-central/rev/b0b87b3bc2dc

Comment 31

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Will verify after in a day or two after I get new update with the patch.

Comment 32

[Will Roberts [:bws42]]

The Nightly built from https://hg.mozilla.org/mozilla-central/rev/6f63f95e28ffc05c0d2f5ef6cd6e05905fe8ea5a

now works as expected for me.

Comment 33

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Build 20161230030205 works again for me too.

Comment 34

[Andrei Vaida [:avaida]]

Updating status flags based on Comment 32 and Comment 33.