Closed
Bug 1322137
Opened 8 years ago
Closed 8 years ago
Port bug 821291. Remove MOZ_ENABLE_GNOME_COMPONENT from c-c
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(thunderbird53 fixed, seamonkey2.50 fixed)
RESOLVED
FIXED
Thunderbird 53.0
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
|
2.60 KB,
patch
|
aleth
:
review+
philip.chee
:
review+
|
Details | Diff | Splinter Review |
Bug 821291 folded mozgnome.so into libxul and external binary compnents are no longer supported anyway. The only reference where MOZ_ENABLE_GNOME_COMPONENT is still used is in suite. IM and TB only declare it. I think it can be safely removed.
|
Assignee | |
Comment 1•8 years ago
|
||
Need to do a Linux build first before setting review.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8816901 [details] [diff] [review] 1322137-mozgnome.patch SeaMonkey Linux build did build and worked. I think IM and TB parts can be removed without a try build.
Attachment #8816901 -
Flags: review?(philip.chee)
Attachment #8816901 -
Flags: review?(aleth)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8816901 [details] [diff] [review] 1322137-mozgnome.patch Review of attachment 8816901 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the cleanup
Attachment #8816901 -
Flags: review?(aleth) → review+
|
|
||
Updated•8 years ago
|
Attachment #8816901 -
Flags: review?(philip.chee) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/edfe6af9e70592537a05d22efad7de6a723a8217
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-seamonkey2.50:
--- → fixed
status-thunderbird53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in
before you can comment on or make changes to this bug.
Description
•