1322531 - Use a different icon in captive portal error page

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

A small, relatively easy improvement to the captive portal experience is to show a more relevant icon in the error page (once bug 989197 lands). For example, Philipp suggested we show a "WiFi" icon instead.

To be clear: this is instead of the "info" icon (i with a circle around it).

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: wifi.svg

Here's the icon! Let me know if that works.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1322531 - Use a different icon in captive portal error page.

Review commit: https://reviewboard.mozilla.org/r/103070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103070/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

https://reviewboard.mozilla.org/r/103070/#review103700

I didn't test this but patch but it looks fine to me.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

https://reviewboard.mozilla.org/r/103070/#review103812

r=me but please tidy up the SVG.

::: browser/themes/shared/incontent-icons/wifi.svg:1
(Diff revision 1)
> +<?xml version="1.0" encoding="utf-8"?>

Please see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/SVG_Guidelines .

You will need a license, and you should omit the xlink namespace as it's unused.

The width/height/viewbox is also confusing and look wrong.

cls-1 seems unnecessary, and cls-3 I expect can be an attribute. Please rename cls-2 to something more meaningful.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/103070/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e054b0a0e5f7
Use a different icon in captive portal error page. r=Gijs,MattN

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e054b0a0e5f7

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

Approval Request Comment
[User impact if declined]: This patch makes the icon shown in the captive portal error page more relevant.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no, just an icon change
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

new icon for captive portal error page, aurora52+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d387b2aa3dc2