Closed Bug 1322946 Opened 8 years ago Closed 4 years ago

Add more tests for <dialog> "close" event

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

      No description provided.
Summary: Support "close" event on dialog → Add more tests for <dialog> "close" event
Priority: -- → P3
Unassigning to reflect real status.
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW

Tim, I am not sure what we need to add for this bug, and I think the wpt test have it well covered https://github.com/web-platform-tests/wpt/blob/master/html/semantics/interactive-elements/the-dialog-element/dialog-close.html.

So I am closing this, but feel free to reopen it :)

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX

oh I misread the title, I was thinking the close method.

I sorted of added some "close" event test in bug 1322947, but I think I can/should add one just for this event particularly.

Reopening!

Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Actually, the "close" event gets its own coverage at here, and as I mentioned in the above comment, the tests of the "close" event that should be fired when the dialog is canclled gets covered in bug 1322947.

So I changed my mind again and I think we are good. Sorry for the spamming.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.