Closed
Bug 1322975
Opened 8 years ago
Closed 7 years ago
devedition.inc.css can stop resetting padding-top and padding-bottom on #nav-bar-customization-target
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: dao, Assigned: aniruddhavivekpatil, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
717 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Bug 1322430 made the Mac theme not set padding-top and padding-bottom on #nav-bar-customization-target anymore. The Windows and Linux themes didn't set padding-top or padding-bottom in the first place. This means that #nav-bar-customization-target is now redundant here: https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/themes/shared/devedition.inc.css#234
Reporter | ||
Updated•8 years ago
|
Priority: -- → P3
Reporter | ||
Updated•8 years ago
|
Mentor: dao+bmo
Assignee | ||
Comment 1•7 years ago
|
||
Hello! I would like to take up this bug. Since this is my first bug, a little information on how to get started would help me greatly.
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Aniruddha Patil from comment #1) > Hello! I would like to take up this bug. Since this is my first bug, a > little information on how to get started would help me greatly. Have you already built Firefox? https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2) > (In reply to Aniruddha Patil from comment #1) > > Hello! I would like to take up this bug. Since this is my first bug, a > > little information on how to get started would help me greatly. > > Have you already built Firefox? > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ > Build_Instructions/Simple_Firefox_build Yes. I've built it.
Reporter | ||
Comment 4•7 years ago
|
||
The next step would be to open browser/themes/shared/devedition.inc.css in the editor of your choice and make the change that I described in comment 0.
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > The next step would be to open browser/themes/shared/devedition.inc.css in > the editor of your choice and make the change that I described in comment 0. I have removed the redundancy as you had described.
Reporter | ||
Comment 6•7 years ago
|
||
Have you created a patch?
Assignee | ||
Comment 7•7 years ago
|
||
No. How do I make one?
Reporter | ||
Comment 8•7 years ago
|
||
The simplest way is hg diff: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_diff_and_patch_files.3F
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #8) > The simplest way is hg diff: > > https://developer.mozilla.org/en-US/docs/Mercurial/ > Using_Mercurial#How_can_I_diff_and_patch_files.3F I have made a local commit. Using hg push review tells me to provide an ircnick. But I do not have one. How do I proceed further?
Reporter | ||
Comment 10•7 years ago
|
||
Not sure how that works. After committing you can also just export the patch using hg export, then upload the patch file manually as an attachment on this bug page.
Assignee | ||
Comment 11•7 years ago
|
||
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #10) > Not sure how that works. After committing you can also just export the patch > using hg export, then upload the patch file manually as an attachment on > this bug page. I have attached the patch as you said.
Reporter | ||
Comment 13•7 years ago
|
||
Comment on attachment 8819756 [details] [diff] [review] bug1322975.patch Perfect, thanks!
Attachment #8819756 -
Flags: review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → aniruddhavivekpatil
Comment 14•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5926190be105 Removed the redundant #nav-bar-customization-target in devedition.inc.css. r=dao
Assignee | ||
Comment 15•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #13) > Comment on attachment 8819756 [details] [diff] [review] > bug1322975.patch > > Perfect, thanks! Thanks for the guidance! :)
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5926190be105
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•