1323079 - Intermittent dom/media/tests/mochitest/test_peerConnection_trackDisabling_clones.html | Test timed out.

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=40500709&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32/1481573265/mozilla-inbound_win7_vm_test-mochitest-media-bm139-tests1-windows-build163.txt.gz

Comment 1

[Andreas Pehrson [:pehrsons]]

This is timing out when checking remote video for being black while disabled locally.

After disabling we only send one disabled frame. We might have to change that to send more, at a lower rate perhaps, since with packet loss the remote side might never receive the black frame, or with high load on the sender or with low bandwidth it might never get sent.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Having disable get a black frame across is moderately important; bumping to low p2

Comment 3

[Intermittent Failures Robot]

9 failures in 526 pushes (0.017 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 4
* autoland: 4
* mozilla-central: 1

Platform breakdown:
* windows7-32-vm: 6
* linux32: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2016-12-12&endday=2016-12-18&tree=all

Comment 4

[Intermittent Failures Robot]

9 failures in 609 pushes (0.015 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* linux64: 4
* windows7-32-vm: 2
* linux32: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2016-12-19&endday=2016-12-25&tree=all

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1323079 - Send disabled frames no more often than 1 FPS over WebRTC.

Review commit: https://reviewboard.mozilla.org/r/101174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101174/

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8822195 [details]
Bug 1323079 - Send disabled frames no more often than 1 FPS over WebRTC.

https://reviewboard.mozilla.org/r/101174/#review102920

::: media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:199
(Diff revision 1)
>          return;
>        }
>  
> -      disabled_frame_sent_ = true;
> +      disabled_frame_sent_ = t;
>      } else {
> -      disabled_frame_sent_ = false;
> +      // This sets it to the null moment.

"to the Null time"

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8822195 [details]
Bug 1323079 - Send disabled frames no more often than 1 FPS over WebRTC.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101174/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d0fd553e1d0
Send disabled frames no more often than 1 FPS over WebRTC. r=jesup

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d0fd553e1d0

Comment 10

[Intermittent Failures Robot]

1 failures in 792 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2017-11-27&endday=2017-12-03&tree=all