Closed Bug 1323115 Opened 8 years ago Closed 7 years ago

Enable BaselineJIT on aarch64

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Platform:
Other
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: denis.scott.v, Assigned: denis.scott.v)

References

Details

Attachments

(1 file, 1 obsolete file)

v2.patch
2.06 KB, patch
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
Attached patch BaselineJIT-AARCH64.patch (obsolete) — — Splinter Review 

        Attachment #8818149 -
        Flags: review?(bbouvier)

    
  
OS: Unspecified → Linux
Hardware: Unspecified → Other

    
  

        Attachment #8818149 -
        Flags: review?(bbouvier) → review?(jdemooij)

    
    

    
  
Comment on attachment 8818149 [details] [diff] [review]
BaselineJIT-AARCH64.patch

Move to Review Board.

        Attachment #8818149 -
        Attachment is obsolete: true

        Attachment #8818149 -
        Flags: review?(jdemooij)

    
    

    
  
Comment on attachment 8818149 [details] [diff] [review]
BaselineJIT-AARCH64.patch

Upload patch to reviewboard failed :-(

        Attachment #8818149 -
        Attachment is obsolete: false

        Attachment #8818149 -
        Flags: review?(jdemooij)

    
    

    
  
Comment on attachment 8818149 [details] [diff] [review]
BaselineJIT-AARCH64.patch

Review of attachment 8818149 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

Looks good to me, but I'm requesting an additional review from Jakob, who was the last to work on the ARM64 code. Jakob, can you think of any reason not to do this?

        Attachment #8818149 -
        Flags: review?(jolesen)

        Attachment #8818149 -
        Flags: review?(jdemooij)

        Attachment #8818149 -
        Flags: review+

    
    

    
  
Thanks!
It seems jakob hasn't login bugzilla for a long time

    
    

    
  
Comment on attachment 8818149 [details] [diff] [review]
BaselineJIT-AARCH64.patch

Adding an additional review from Sean in case Jakob is on PTO or something.

        Attachment #8818149 -
        Flags: review?(sstangl)

    
    

    
  
Comment on attachment 8818149 [details] [diff] [review]
BaselineJIT-AARCH64.patch

Review of attachment 8818149 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. The baseline JIT is tested with the simulator, so it should be OK. The Ion JIT does not work yet.

        Attachment #8818149 -
        Flags: review?(jolesen) → review+
Assignee: nobody → denis.scott.v
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed

        Attachment #8818149 -
        Flags: review?(sstangl)

    
    

    
  
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c216703bd7e2
Enable BaselineJIT on aarch64. r=jdemooij
Keywords: checkin-needed

    
    

    
  
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dce91a5322a
Backed out changeset c216703bd7e2 for bustage

    
    

    
  
bustage -> https://treeherder.mozilla.org/logviewer.html#?job_id=40937538&repo=mozilla-inbound sorry had to back this out
Flags: needinfo?(denis.scott.v)

    
    

    
  
I have no idea how to solve this issue. There is no problem on Linux-x64.
Flags: needinfo?(denis.scott.v)

    
    

    
  
I think the problem is that we #include "jit/arm64/vixl/Cpu-vixl.h" unconditionally and it doesn't compile on Windows. The code on line 103 in Instructions-vixl.h. I think it'd be okay for now to #include that header only if JS_CODEGEN_ARM64.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8818149 -
        Attachment is obsolete: true

    
    

    
  
Thanks!

    
    

    
  
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da3671e1528c
Enable BaselineJIT on aarch64. r=jandem,jolesen

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/da3671e1528c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox53:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

    
  
Depends on: 1359051

    
  
Depends on: 1359142

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: