1323665 - stylo: several tests fatally assert with "stylo: unimplemented SetEnabled"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Cameron McCormack (:heycam)]

gfx/tests/crashtests/398042-1.xhtml
gfx/tests/crashtests/398042-2.xhtml
layout/base/crashtests/234851-1.html
layout/base/crashtests/386266-1.html
layout/base/crashtests/460389-1.html
layout/base/crashtests/492112-1.xhtml
layout/generic/crashtests/469859-1.xhtml

Comment 2

[Cameron McCormack (:heycam)]

layout/svg/crashtests/477935-1.html

Comment 3

[Cameron McCormack (:heycam)]

netwerk/test/crashtests/785753-1.html
view/crashtests/281743-1.html

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

layout/style/test/test_bug1089417.html

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

layout/style/test/test_redundant_font_download.html

Comment 6

[Shing Lyu [:shinglyu]]

reftest crashes with signature @ mozilla::StyleSheet::SetDisabled

layout/reftests/table-anonymous-boxes/208305-2.html
layout/reftests/table-anonymous-boxes/208305-4.html
layout/reftests/bugs/360746-1.html
layout/reftests/font-face/enable-sheet-1.html
layout/reftests/font-face/enable-sheet-2.html
layout/reftests/font-face/enable-sheet-3.html
layout/reftests/font-face/enable-sheet-4.html
layout/reftests/font-face/enable-sheet-5.html
layout/reftests/font-face/enable-sheet-6.html
layout/reftests/font-face/enable-sheet-7.html
layout/reftests/first-letter/229764-2.html
layout/reftests/font-face/disable-sheet-1.html
layout/reftests/font-face/disable-sheet-4.html
layout/reftests/font-face/disable-sheet-5.html
layout/reftests/font-face/underline-offset-change-1.html
layout/reftests/font-face/underline-offset-change-2.html
layout/reftests/font-face/dynamic-duplicate-rule-1a.html
layout/reftests/font-face/dynamic-duplicate-rule-1c.html
layout/reftests/font-face/dynamic-duplicate-rule-1b.html

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Bug 1323665 - Part 1: Adjust some ServoStyleSet assertions.

We're incorrectly asserting that a sheet is applicable when we remove it from
the style set, but we'll actually cause the sheet to be not applicable just
before we remove it from the style set.  (Note how nsStyleSet doesn't assert
this in RemoveStyleSheet.)  Also, we were missing a corresponding assertion
in AddDocStylesSheet.

Review commit: https://reviewboard.mozilla.org/r/103278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103278/

Comment 8

[Cameron McCormack (:heycam)]

Attachment: Bug 1323665 - Part 2: Allow StyleSheet.disabled CSSOM access to disable/enable a ServoStyleSheet.

Now that bug 1290209 has landed, we can make StyleSheet.disabled work in Servo
styled documents.  This fixes a bunch of test crashes due to the assertion no
longer firing.

Review commit: https://reviewboard.mozilla.org/r/103280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103280/

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8824932 [details]
Bug 1323665 - Part 2: Allow StyleSheet.disabled CSSOM access to disable/enable a ServoStyleSheet.

https://reviewboard.mozilla.org/r/103280/#review103800

Comment 10

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8824931 [details]
Bug 1323665 - Part 1: Adjust some ServoStyleSet assertions.

https://reviewboard.mozilla.org/r/103278/#review103802

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d832600dd897
Part 1: Adjust some ServoStyleSet assertions. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/3c6af7904a1d
Part 2: Allow StyleSheet.disabled CSSOM access to disable/enable a ServoStyleSheet. r=xidorn

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d832600dd897
https://hg.mozilla.org/mozilla-central/rev/3c6af7904a1d