1323998 - Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P4)

Description

[:Cykesiopka]

Scoped.h is deprecated.

Comment 1

[:Cykesiopka]

Attachment: Bug 1323998 - Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp.

Scoped.h is deprecated.

Review commit: https://reviewboard.mozilla.org/r/99838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99838/

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8820314 [details]
Bug 1323998 - Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp.

https://reviewboard.mozilla.org/r/99838/#review100442

LGTM, if you can fix the constructor for DtlsIdentity.  I only found two call sites: https://dxr.mozilla.org/mozilla-central/search?q=%2Bcallers%3A%22mozilla%3A%3ADtlsIdentity%3A%3ADtlsIdentity%28SECKEYPrivateKey+%2A%2C+CERTCertificate+%2A%2C+SSLKEAType%29%22

::: media/mtransport/dtlsidentity.h:26
(Diff revision 1)
>  
>  class DtlsIdentity final {
>   public:
>    // This constructor takes ownership of privkey and cert.
>    DtlsIdentity(SECKEYPrivateKey *privkey,
>                 CERTCertificate *cert,

I think that you should change this to accept Unique{SECKEYPrivateKey|CERTCertificate)&& and use Move() at the call sites.

Comment 3

[:Cykesiopka]

Comment on attachment 8820314 [details]
Bug 1323998 - Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp.

https://reviewboard.mozilla.org/r/99838/#review100442

Thanks!

> I think that you should change this to accept Unique{SECKEYPrivateKey|CERTCertificate)&& and use Move() at the call sites.

Fixed, although I used plain UniqueX instead of UniqueX&& to make it clear that `DtlsIdentity` unconditionally takes ownership.

Comment 4

[:Cykesiopka]

Comment on attachment 8820314 [details]
Bug 1323998 - Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99838/diff/1-2/

Comment 5

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2856287b145560823a26a2efb6fd6e3039eaaad1
Orange X(10) looks like an intermittent.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/294ce2352aa7
Stop using Scoped.h NSS types in dtlsidentity.(cpp|h) and nricectx.cpp. r=mt

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/294ce2352aa7