Closed
Bug 1324113
Opened 7 years ago
Closed 7 years ago
NSD_FreeImage called on wrong handle
Categories
(Firefox :: Installer, defect, P5)
Tracking
()
RESOLVED
INVALID
People
(Reporter: agashlin, Unassigned)
Details
https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/installer/windows/nsis/stub.nsi#861 https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/installer/windows/nsis/stub.nsi#1405 These calls use $0, intending to free handles from lines 835 and 1322 respectively, but $0 has been clobbered in the meanwhile. This may result in a small memory leak.
Updated•7 years ago
|
Priority: -- → P5
Comment 1•7 years ago
|
||
This has been resolved by removing the intro screen; remaining NSD_FreeImage calls are made with a variable instead of a register, and there's only one image at a time for them to free.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•