1324117 - Enable APZ scrollbar dragging on Nightly

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

As mentioned in bug 1251617 comment 5, I think we're now in good enough shape to turn on APZ scrollbar dragging on the Nightly channel.

We have a few remaining known issues (see dependencies of bug 1211610), but they are either hard to reproduce, or hard to fix. Enabling the feature and getting feedback from our Nightly user base will likely result in more testcases for the hard-to-reproduce bugs, and a sense of how severe the hard-to-fix bugs are.

Comment 1

[Botond Ballo [:botond]]

Kevin, would you like to do the honours and flip the switch? It just involves modifying all.js to set the pref to true inside an #ifdef NIGHTLY_BUILD block. See [1] for an exmaple.

[1] http://searchfox.org/mozilla-central/rev/f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671

Comment 2

[Kevin Wern]

Attachment: Bug 1324117 - Enable APZ scrollbar dragging on Nightly

Review commit: https://reviewboard.mozilla.org/r/99234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99234/

Comment 3

[Kevin Wern]

(In reply to Botond Ballo [:botond] from comment #1)
> Kevin, would you like to do the honours and flip the switch? It just
> involves modifying all.js to set the pref to true inside an #ifdef
> NIGHTLY_BUILD block. See [1] for an exmaple.
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> f680e72cc6579f90b992b63ca14d923d2afea612/modules/libpref/init/all.js#671

Done. Let's hope for the best :).

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8819482 [details]
Bug 1324117 - Enable APZ scrollbar dragging on Nightly

https://reviewboard.mozilla.org/r/99234/#review99954

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8615f78ac4f4
Enable APZ scrollbar dragging on Nightly r=botond

Comment 6

[Botond Ballo [:botond]]

Thanks, Kevin!

I announced the enablement on the dev-platform mailing list [1], so people know where to file bugs if they encounter any regressions.

[1] https://groups.google.com/forum/#!topic/mozilla.dev.platform/_65Nu8PphT4

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/autoland/rev/90f2fd2c7ee34a6079c7fd3d8cd3f7ab32537eb1 for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=8124350&repo=autoland

Comment 8

[Botond Ballo [:botond]]

My bad, I should have pushed to Try before landing.

I filed bug 1324581 for fixing this test. Kevin, let me know if you're interested in working on it.

Comment 9

[Botond Ballo [:botond]]

Try push for this bug + bug 1324581: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b979d3f7d7821b94a21c104dfaf7f270b8dd439c

Comment 10

[Botond Ballo [:botond]]

The Try push looks green, and I already landed bug 1324581.

In order for me to re-land this patch using Autoland, you need to re-open the review request. Could you do so? There should be a "Reopen for Review" button at https://reviewboard.mozilla.org/r/99232/.

Comment 11

[Kevin Wern]

Just reopened it.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7518eef6b89
Enable APZ scrollbar dragging on Nightly r=botond

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d7518eef6b89

Comment 14

[Benoit Girard (:BenWa)]

Amazing work, I'm glad to see this shipping :D!

I had filed a serious blocker bug 1250649. I wonder if it's still an issue? needinfo me if you want any details.

Comment 15

[Benoit Girard (:BenWa)]

Ohh I just re-read the announcement and it looks like it's still on radar. Sorry for the noise.

Comment 16

[Botond Ballo [:botond]]

(In reply to Benoit Girard (:BenWa) from comment #14)
> I had filed a serious blocker bug 1250649. I wonder if it's still an issue?
> needinfo me if you want any details.

We're looking for a URL that reproduces that issue. If you have one, please post it there.

Comment 17

[Benoit Girard (:BenWa)]

I tried to reproduce this artificially and I couldn't. See the bug for more info. Good stuff!