1324204 - Cert error page: Error code link in 'Technical details' shown as html code

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

STR:
1. Go to https://subdomain.preloaded-hsts.badssl.com/
2. Expand Technical Details

Expected:

subdomain.preloaded-hsts.badssl.com uses an invalid security certificate.

The certificate is only valid for the following names:
*.badssl.com, badssl.com

Error code: SSL_ERROR_BAD_CERT_DOMAIN

Actual:

subdomain.preloaded-hsts.badssl.com uses an invalid security certificate.

The certificate is only valid for the following names:
*.badssl.com, badssl.com 

Error code: <a id="errorCode"
title="SSL_ERROR_BAD_CERT_DOMAIN">SSL_ERROR_BAD_CERT_DOMAIN</a>

---------------------------------------------------------------
Notes:
Similar Android bug:
Bug 1238382 - cert error page: Error code link in 'Technical details' shown as html code.
Bug 1238382 Bring Android's about:certerror and about:neterror closer to the desktop versions.
https://hg.mozilla.org/mozilla-central/rev/1292ce950e07

Bug 431826 - Redesign certificate error page for Firefox as about:certerror.

addDomainErrorLink added in:
Bug 402210 - Should SSL Error page for domain mismatch hyperlink to correct site?

addDomainErrorLink() became addDomainErrorLinks() in:
Bug 1207146 - Add a link to expert technical information in the cert error page.
https://hg.mozilla.org/releases/mozilla-esr45/rev/de962dcbc06c
Which is also where the error code was introduced.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

This patch DOES NOT implement the click event handler for the Error Code. I'm going to spin that into a new bug. This bug only fixes ONE ISSUE as per summary.

Comment 2

[Ian Neal]

Comment on attachment 8819542 [details] [diff] [review]
Patch v1.0 Proposed fix

>+  if (!firstResult) {
>+      sd.textContent = desc;
>+      return;

Do we need to set sd.textContent here as Firefox don't seem to?

r/a=me with that addressed/answered.

Comment 3

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/8bc108f04b93ea2a9d8fc2552f60b5205b6c2293