Closed
Bug 1324419
Opened 7 years ago
Closed 7 years ago
Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
11.63 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
See https://dxr.mozilla.org/mozilla-central/rev/2824deb82146bba070995a762cfc98ddb2d1decb/netwerk/protocol/http/HttpChannelParent.cpp#162 for an example. Change code patched in bug 1318759 to use it instead.
Updated•7 years ago
|
Assignee: nobody → honzab.moz
Whiteboard: [necko-active]
Assignee | ||
Comment 2•7 years ago
|
||
I found out that we already have it implemented, landed as part of bug 1024730. Converting the bug appropriately.
Status: NEW → ASSIGNED
Summary: Allow QueryObject to nsHttpChannel → Switch from HttpBaseChannel::QueryHttpChannelImpl to QueryObject(nsHttpChannel)
Assignee | ||
Comment 3•7 years ago
|
||
- removes the redundant QueryHttpChannelImpl method - few of the static_cast<nsHttpChannel*> switched to do_QueryObject(), regardless whether are considered safe or not https://treeherder.mozilla.org/#/jobs?repo=try&revision=696ca75ecb12ed30f0672d9dd80d595ef09970bb
Attachment #8838585 -
Flags: review?(mcmanus)
Comment 4•7 years ago
|
||
Comment on attachment 8838585 [details] [diff] [review] v1 Review of attachment 8838585 [details] [diff] [review]: ----------------------------------------------------------------- thanks for the cleanup
Attachment #8838585 -
Flags: review?(mcmanus) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a622d810dcb5 Use QueryObject for nsHttpChannel. r=mcmanus
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a622d810dcb5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•