132485 - built-in root certs slot description is empty

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

From mozilla/security/nss/lib/ckfw/builtins/constants.c :

NSS_IMPLEMENT_DATA const NSSUTF8 *
nss_builtins_SlotDescription = (NSSUTF8 *) "";

This causes the slot to show up as blank in modutil . Don't we want something
listed there ?

Comment 1

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 2

[Wan-Teh Chang]

Set target milestone to NSS 3.5.

Comment 3

[Wan-Teh Chang]

Bob, what should the slot description for the
builtins be?

Comment 4

[Wan-Teh Chang]

Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Remove target milestone of 3.8, since these bugs didn't get into that release.

Comment 6

[Julien Pierre]

Attachment: Add a string

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 271171 [details] [diff] [review]
Add a string

Maybe "NSS Builtin Root certs" ?
I want to ask Bob for SR on this, in case there is any inobvious effect of this change.

Comment 8

[Robert Relyea]

Comment on attachment 271171 [details] [diff] [review]
Add a string

sr=relyea.

though I do like the idea of including the words 'Root Certs' in the module name.
If the string is changed, be sure it fits in 32 bytes.

Comment 9

[Julien Pierre]

Nelson, Bob, thanks for the reviews. I checked this in on the trunk.

Checking in constants.c;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/constants.c,v  <--  constants.c
new revision: 1.12; previous revision: 1.11
done