1324869 - Make `mach vendor rust` work with homebrew openssl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

The mach vendor rust command fails on MacOS 10.12 installing `cargo-vendor` because it uses openssl-sys as a dependendency, but MacOS no longer provides a system version.

It's common to have homebrew install a version in /usr/local/opt/openssl/ but special flags are needed to access this.

I think we should check for this case and have mach supply the relevant flags.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1324869 - Make 'mach vendor rust' work with Homebrew OpenSSL.

MacOS doesn't include openssl any more, but the cargo-vendor
build expects a system version. Special case using a copy
in /usr/local/opt/openssl, where homebrew typically installs it.

Review commit: https://reviewboard.mozilla.org/r/99878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99878/

Comment 2

[Ralph Giles (:rillian)]

I wonder if we should add openssl to the bootstrap package list on osx too. Saves a step for now, but I expect this to get fixed upstream soon; the openssl-sys dep has been broken for several MacOS releases now.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8820378 [details]
Bug 1324869 - Make 'mach vendor rust' work with Homebrew OpenSSL.

https://reviewboard.mozilla.org/r/99878/#review100378

I'm going to trust that you got all the paths right and tested this locally.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8820378 [details]
Bug 1324869 - Make 'mach vendor rust' work with Homebrew OpenSSL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99878/diff/1-2/

Comment 5

[Ralph Giles (:rillian)]

(In reply to Nathan Froyd [:froydnj] from comment #3)

> I'm going to trust that you got all the paths right and tested this locally.

Thanks. I tested on Mac and Linux, but not Windows. I left the not-found case as a warning in the hope we'd not break anyone's non-standard config. Pushed some typo fixes, carrying r=froydnj.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d721b28ee3e6
Make 'mach vendor rust' work with Homebrew OpenSSL. r=froydnj

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d721b28ee3e6