1325056 - Pause button on videos while RDM activated is faulty

Status: NEW

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

[Affected versions]:
 Fx 52.0a2 (20161219004024)
 Fx 53.0a1 (20161219030207)


[Affected platforms]:
 Windows 10 x64
 Ubuntu 14.04 LTS
 Mac OS X 10.12

[Steps to reproduce]:
 1. Open Firefox.
 2. Go to "www.youtube.com"
 3. Play a random video.
 4. Open RDM(ctrl/cmd+shift+m).
 5. Select any mobile device.
 6. Pause the video.

[Expected result]:
 The pause button works accordingly.

[Actual result]:
 The pause button resumes the video after a second.It takes a few tries to pause the button.

[Regression range]:
 This issue is not a regression as it is reproducible ever since it was implemented.

[Notes]:
 a. Gif with the issue: http://imgur.com/a/NCmlS .
 b. This issue also reproduces with Facebook clips.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for filing!

At first glance, this seems to be an issue with how we're simulating touch events.  You can also click the hand icon to enable touch simulation (step 5 of selecting a mobile device is the same, since it enables touch by default).

If you use a touch event test page like https://mozilla.github.io/mozhacks/touch-events/event-listener.html, you can see the events that we're currently sending through:

touchstart
touchend
mousedown
mouseup
click

Checking in the Chrome Canary 57 responsive mode, they also send essentially the same events (with some pointer versions added), but the issue doesn't appear there.  However, the control UI for <video> is implemented by the browser, so it makes sense for this issue to be Firefox specific.

It seems like the core issue is that videocontrols.xml uses a system group click listener, so it receives a click event even though the simulator has already called `stopImmediatePropagation`.

Maybe this would be fixed by also using system group listeners in the simulator too...?