1325101 - service worker no-fetch optimization doesn't seem to work

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

I tried testing the latest nightly on some sites I know only use push notifications.  AFAICT, the service worker is still starting up.  For example, try this site:

  https://gauntface.github.io/simple-push-demo/

I opened up the serviceworkers.txt file to see if I was running the version with the new info and it appears I am:

https://gauntface.github.io/simple-push-demo/
https://gauntface.github.io/simple-push-demo/service-worker.js
true
{3280b85a-c2ae-4f7f-b005-abd4fe3ca9d2}

We're just selecting true for the fetch handler boolean for some reason.

Catalin, can you take a look?

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

It seems we should only do this for `addEventListener('fetch')`:

https://dxr.mozilla.org/mozilla-central/source/dom/workers/WorkerScope.cpp#693

I think right now we set the flag if there are any event handlers.  Sorry I missed this in review!

Comment 2

[Cătălin Badea (:catalinb)]

Attachment: Don't set fetch handler flag for events other than 'fetch'.

Somehow, I removed the if('fetch') line when changing from throwing to warning.

Comment 3

[Cătălin Badea (:catalinb)]

Tested on https://gauntface.github.io/simple-push-demo/, the patch fixes the issue.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

I'll review this afternoon, but can you also update one of the automated test cases to catch this?

Comment 5

[Cătălin Badea (:catalinb)]

Attachment: Update nofetch handler mochitest.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8820818 [details] [diff] [review]
Update nofetch handler mochitest.

Review of attachment 8820818 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Cătălin Badea (:catalinb)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c5a624e9225650eb52658ea4e3bcae4de3cbe0d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa14643296e8
Don't set fetch handler flag for events other than 'fetch'. r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/38f5c47acbe1
Update nofetch handler mochitest. r=bkelly

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa14643296e8
https://hg.mozilla.org/mozilla-central/rev/38f5c47acbe1