1325123 - Space above tabs is 1px too big on Windows 10 (2px instead of 1px)

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[Will]

Attachment: freespace.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161208153507

Steps to reproduce:

this is slowly driving me nuts and I had to finally file it: using v50.1 stable on a Surface Pro 4, all settings are default. When Firefox is maximized, there is a pixel or 2 too much empty space above the focused tab! The GUI should be moved up 1 or 2 pixels. I know it's sounds silly but we shouldn't waste precious vertical space even if it's only 1 pixel and also it looks like firefox isn't FULLY maximized even though it is . I attached a screenshot

Comment 1

[:Gijs (he/him)]

I'm fairly sure this is intentional. Stephen?

Comment 2

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #1)
> I'm fairly sure this is intentional. Stephen?

Yes. It's there to give a little buffer to maintain the tab shape outline against the tabstrip background. It was a little more obvious on Windows 7 where we had a roughly 2px border + shadow but it works on Windows 10 as well.

Comment 3

[Will]

I understand now. Would you consider reducing it to 1 instead of the current 2? (It looks like 3 on my computer but I could be wrong)

(In reply to Stephen Horlander [:shorlander] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > I'm fairly sure this is intentional. Stephen?
> 
> Yes. It's there to give a little buffer to maintain the tab shape outline
> against the tabstrip background. It was a little more obvious on Windows 7
> where we had a roughly 2px border + shadow but it works on Windows 10 as
> well.

Comment 4

[:Gijs (he/him)]

Hm, seems there's a theme bug. I believe it should be 1 CSS pixel (which might then end up looking bigger on your hidpi screen, as you noted), but it looks to me like there's 2 right now (checked with screenshots on my lodpi machine). There's only 1 on e.g. Windows 7. That's just a bug, I think.

Off-hand, I suspect we're using a transparent border at the top of the tab and haven't taken its default 1px height into account here (tabs have borders on all other versions of Windows and on other OSes). But I haven't investigated in detail.

Comment 5

[:Gijs (he/him)]

(In reply to :Gijs (gone until 3 jan) from comment #4)
> Hm, seems there's a theme bug. I believe it should be 1 CSS pixel (which
> might then end up looking bigger on your hidpi screen, as you noted), but it
> looks to me like there's 2 right now (checked with screenshots on my lodpi
> machine). There's only 1 on e.g. Windows 7. That's just a bug, I think.

Eh, let's doublecheck Stephen agrees...

Comment 6

[Tim Nguyen :ntim]

I don't think this is relevant with photon anymore... Please reopen if it still is.