Closed
Bug 1325155
Opened 7 years ago
Closed 7 years ago
Convert text selection events to bundle events
Categories
(GeckoView :: General, defect)
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(2 files)
2.63 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
26.38 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Add overrides for Object methods in GeckoBundle, and redirected them to the corresponding methods in SimpleArrayMap. For equals, a custom implementation is used because the equals implementation in SimpleArrayMap had bugs across different support library versions.
Attachment #8820828 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 2•7 years ago
|
||
Convert the "TextSelection:*" events to use BundleEventListener / GeckoBundle, in both ActionBarTextSelection.java and FloatingToolbarTextSelection.java. UI events are used because the listeners require the UI thread. The "TextSelection:Update" listeners are removed because the event is no longer sent by ActionBarHandler.
Attachment #8820829 -
Flags: review?(s.kaspari)
Comment 3•7 years ago
|
||
Comment on attachment 8820828 [details] [diff] [review] 1. Add Object overrides for GeckoBundle (v1) Review of attachment 8820828 [details] [diff] [review]: ----------------------------------------------------------------- I wonder if it makes sense to add a junit4 test for GeckoBundle? Should be pretty straight forward. ::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoBundle.java @@ +663,5 @@ > + } > + > + @Override // Object > + public String toString() { > + return mMap.toString(); Ah, that's a good thing to have. I recently wrote this locally too, for debugging. > public String toString() { > return "GeckoBundle[" + mMap.toString() + "]"; > }
Attachment #8820828 -
Flags: review?(s.kaspari) → review+
Updated•7 years ago
|
Attachment #8820829 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #3) > Comment on attachment 8820828 [details] [diff] [review] > 1. Add Object overrides for GeckoBundle (v1) > > Review of attachment 8820828 [details] [diff] [review]: > ----------------------------------------------------------------- > > I wonder if it makes sense to add a junit4 test for GeckoBundle? Should be > pretty straight forward. Filed bug 1326101; would be a nice intern project.
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/58e189739172 1. Add Object overrides for GeckoBundle; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/2a43ca16d1c1 2. Convert text selection events to bundle events; r=sebastian
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/58e189739172 https://hg.mozilla.org/mozilla-central/rev/2a43ca16d1c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 53 → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•