1325239 - Pocket strings typo in es-MX and ast locales

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[(Away)]

This should say "Pocket" instead of "Pocker":
https://dxr.mozilla.org/mozilla-central/rev/c36fbe84042debef0a5d58b7fc88185b401762ce/browser/extensions/pocket/locale/es-MX/pocket.properties#27

I don't speak Asturian but I bet this is also incorrect:
https://dxr.mozilla.org/mozilla-central/rev/c36fbe84042debef0a5d58b7fc88185b401762ce/browser/extensions/pocket/locale/ast/pocket.properties#27

Comment 1

[(Away)]

Pike, do you mind helping me route this to the right owners? I can provide a patch if needed, but I don't know how the process works for these things...

Comment 2

[Francesco Lodolo [:flod]]

As a general rule for localization bugs: file one bug per locale since each locale is in a different component of Mozilla Localizations.

For this specific case I've fixed both strings in Pontoon, they will be committed here
https://github.com/mozilla-l10n/pocket-l10n/commits/master

The reality is that we need to dump them to mozilla-* code, and that's done manually.

@Shane
Can you help with that?

Comment 3

[Shane Caraveo (:mixedpuppy)]

When you're ready, mkaply or myself can help.  Are you going to try and hit this uplift?  Will we want to uplift further?

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> When you're ready, mkaply or myself can help.  Are you going to try and hit
> this uplift?  Will we want to uplift further?

At this point I think we don't need to rush. Land mid-cycle next week, then uplift at least to aurora.

Comment 5

[Francesco Lodolo [:flod]]

Leave NI to myself to avoid forgetting about this bug.

Comment 6

[Francesco Lodolo [:flod]]

Attachment: Bug 1325239 - Update Pocket string localizations,

Review commit: https://reviewboard.mozilla.org/r/108000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108000/

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

https://reviewboard.mozilla.org/r/107998/#review109110

::: browser/extensions/pocket/locale/en-US/pocket.properties:29
(Diff revision 1)
>  suggestedtags = Suggested Tags
>  tagline = Save articles and videos from Firefox to view in Pocket on any device, any time.
>  taglinestory_one = Click the Pocket Button to save any article, video or page from Firefox.
>  taglinestory_two = View in Pocket on any device, any time.
>  tagssaved = Tags Added
> -tos = By continuing, you agree to Pocket's <a href="%1$S" target="_blank">Terms of Service</a> and <a href="%2$S" target="_blank">Privacy Policy</a>
> +tos = By continuing, you agree to Pocket’s <a href="%1$S" target="_blank">Terms of Service</a> and <a href="%2$S" target="_blank">Privacy Policy</a>

Note sure why the current code doesn't have a proper curly apostrophe. This is a copy and paste from the string in the l10n repository.

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

https://reviewboard.mozilla.org/r/108000/#review110050

In the future I think these should be pull requests against the git repo, then pulled into mc.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #8)
> In the future I think these should be pull requests against the git repo,
> then pulled into mc.

Uh, which Git repo? I must have missed that we had one, I'm only aware of the l10n repo (where these strings are coming from).

Comment 10

[Shane Caraveo (:mixedpuppy)]

The repo is at https://github.com/mozilla-partners/pocket

We can backport from mc to git for this patch.

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #10)
> The repo is at https://github.com/mozilla-partners/pocket
> 
> We can backport from mc to git for this patch.

OK, good to know for the future. I'll open PRs against that repo first.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5fbdab74fb
Update Pocket string localizations, r=mixedpuppy

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=73707675&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/f8ee30ddcfe4a667327836c2f1fa318d6ecdba96

Comment 14

[Francesco Lodolo [:flod]]

Sorry, the last thing I was expecting was to have test failures on this kind of patch. I should know better.

Will fix and push to try before asking to land again.

Comment 15

[Francesco Lodolo [:flod]]

Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108000/diff/1-2/

Comment 16

[Francesco Lodolo [:flod]]

Try builds seem green enough
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b4a1ca1c773

Comment 17

[Shane Caraveo (:mixedpuppy)]

cc/mkaply on pocket stuff

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f98263256940
Update Pocket string localizations, r=mixedpuppy

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f98263256940

Comment 20

[Francesco Lodolo [:flod]]

Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

I think we can at least try to uplift this to aurora.

Approval Request Comment
[Feature/Bug causing the regression]: -

[User impact if declined]: Pocket name misspelled in es-MX and ast, missing a few localization updates.

[Is this code covered by automated tests?]: -

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no.

[Why is the change risky/not risky?]: it only affect localizations of Pocket.

[String changes made/needed]: these strings are not exposed for localization through the standard process.

Comment 21

[Mike Kaply [:mkaply]]

Since pocket-l10n is updated from pontoon, will these go in automatically?

https://github.com/mozilla-l10n/pocket-l10n

Comment 22

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #21)
> Since pocket-l10n is updated from pontoon, will these go in automatically?
> 
> https://github.com/mozilla-l10n/pocket-l10n

Pontoon commits directly to that repository. The strings from this patch are taken from there.

Comment 23

[Gerry Chang [:gchang]]

Comment on attachment 8831416 [details]
Bug 1325239 - Update Pocket string localizations,

Fix Pocket string localization issue. Aurora53+.

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f8f9621e75b