1325282 - comm-central should stop using nsIEditorIMESupport

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsIEditorIMESupport will be removed. So, comm-central should stop using it at:
https://dxr.mozilla.org/comm-central/rev/a844bb9580da7b60946d7592d772c7ef5b79da71/editor/ui/composer/content/ComposerCommands.js#891

Now, nsIEditor has all methods/attributes of nsIEditorIMESupport, so, it should just call |editor.forceCompositionEnd()|.

Although, I'm not sure if this code is actually used by Tb.

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. Maybe something in the HTML editor of SM. Philip can you please take a look.

Comment 2

[Jorg K (CEST = GMT+2)]

Daniel, since you commented on bug 1312991, maybe you're interested in this one here, too.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to Jorg K (GMT+1) from comment #2)
> Daniel, since you commented on bug 1312991, maybe you're interested in this
> one here, too.

Thanks for asking. BlueGriffon's code does not use nsIEditorIMESupport beyond
the editor core, so no objection at all.

Comment 4

[Philip Chee]

(In reply to Jorg K (GMT+1) from comment #1)
> Thanks for the heads-up. Maybe something in the HTML editor of SM. Philip
> can you please take a look.
Should not affect us.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1325282-nsIEditorIMESupport.patch

Doing what Masayuki-san suggested.

Comment 6

[Philip Chee]

Comment on attachment 8821515 [details] [diff] [review]
1325282-nsIEditorIMESupport.patch

r=me. Sorry for the delay

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/9bd6f256ea516c871c5a51ebc28d20c36b70cbc5