Closed
Bug 1325356
Opened 7 years ago
Closed 7 years ago
[EME][Fennec] Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder.
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: kikuo, Assigned: kikuo)
References
Details
Attachments
(1 file)
http://searchfox.org/mozilla-central/rev/ac40ca3ec39efe85bfb111274c10ee4ceea5bb7a/dom/media/platforms/android/MediaCodecDataDecoder.cpp#132 This object should exist in the derived class EMEVideoDataDecoder, not the base one.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8821431 [details] Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. https://reviewboard.mozilla.org/r/100724/#review101226 Is there a compile warning for hiding base members?
Attachment #8821431 -
Flags: review?(jwwang) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8821431 [details] Bug 1325356 - Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. https://reviewboard.mozilla.org/r/100724/#review101226 Nope, just traced and found it. Thanks !
Pushed by kikuo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72f2f33715b4 Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/72f2f33715b4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/803ec03e6791 Backed out changeset 72f2f33715b4 for failing tests it added a=backout
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c702cd7fb3ba Remove unnecessary SamplesWaitingForKey object in VideoDataDecoder. r=jwwang
(In reply to Pulsebot from comment #6) (In reply to Pulsebot from comment #7) I accidentally backed this out instead of a different patch, then relanded this. It already made its way to m-c with the original changeset. When the backout and the relanding get merged to m-c, it'll probably comment in here again. Sorry for the churn.
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c702cd7fb3ba
You need to log in
before you can comment on or make changes to this bug.
Description
•