1325690 - Disable Windows a11y+e10s in 52

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

a11y+e10s has been bumped to 53.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Restore Windows a11y checks for e10s

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Modify ContentParent to only initialize a11y on Windows when e10s is force-enabled

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Restore Windows check to "a11y disables e10s" prompt

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8822245 [details] [diff] [review]
Restore Windows a11y checks for e10s

Review of attachment 8822245 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure and test this in an aurora build to be sure it's working as expected.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8822246 [details] [diff] [review]
Modify ContentParent to only initialize a11y on Windows when e10s is force-enabled

Review of attachment 8822246 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for aurora only landing

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8822248 [details] [diff] [review]
Restore Windows check to "a11y disables e10s" prompt

Review of attachment 8822248 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a straight-forward backout of bug 1310788 for Aurora. r=me. Thanks aklotz!

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28d4c12745de

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8822245 [details] [diff] [review]
Restore Windows a11y checks for e10s

Approval Request Comment
[Feature/Bug causing the regression]: a11y on e10s
[User impact if declined]: This feature is not ready to ship in 52.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No. This is a direct landing to Aurora.
[Needs manual test from QE? If yes, steps to reproduce]: Yes.
Case 1: Start 52 normally and verify that 52 starts with e10s enabled in about:support.
Case 2: Start 52 with NVDA running in the background. When it starts, verify in about:support that e10s is disabled due to a11y tools.
[List of other uplifts needed for the feature/fix]: All patches in this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: This change is essentially a backout of bug 1310788 that restores 52's behavior to the same behavior that already exists on 51 Beta and 50 Release. 
[String changes made/needed]: None

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f82df8fc752f

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8822245 [details] [diff] [review]
Restore Windows a11y checks for e10s

disable e10s with a11y for 52

Comment 11

[Julien Cristau [:jcristau]]

Flagging for QE.  Verification steps are in comment 8.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ae057f09650
https://hg.mozilla.org/releases/mozilla-aurora/rev/cbe22ece71ee
https://hg.mozilla.org/releases/mozilla-aurora/rev/d55578d9c7de

Comment 13

[Petruta Horea [:phorea], Desktop QA]

Checked that Firefox 52 beta 1 starts with e10s enabled by default on Win 10 64-bit.

When NVDA is running in the background, 52 beta 1 opens with e10s enabled on the clean profile. After restarting, e10s is disabled by accessibility tools.
"Multiprocess Windows 	0/1 (Disabled by accessibility tools)"