132600 - Refactor ns4xPlugin.cpp

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Kaply [:mkaply]]

There is a very strange #ifdef situation in ns4XPlugin.cpp which makes 
it very difficult for me to create an OS/2 specific section as the 
other platforms have.

In particular

http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/ns4xPlu
gin.cpp#396

should be XP_OS2

I need the fix in this bug, so I can subsequently add in my OS/2 
specific fix for plugins.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Refactor #ifdefs

This patch is essentially adding an XP_OS2 section and an XP_WIN section
whereas before some parts of code were shared and some weren't.

Comment 2

[serge (gone)]

Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

do you relay want to leave this comment?
>+#ifdef XP_OS2
>   // XXX this probably should be factored out and
>   //      just use trailing XP_WIN.

r=serge

Comment 3

[Patrick C. Beard]

Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

sr=beard

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 75400 [details] [diff] [review]
Refactor #ifdefs

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 5

[Mike Kaply [:mkaply]]

fix checked in

Comment 6

[Mike Kaply [:mkaply]]

verified this is fixed.