1326238 - Intermittent dom/media/mediasource/test/test_Eviction_mp4.html | application crashed [@ mozilla::TaskQueue::Dispatch]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=65266896&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/d3ypCfz0QW27K1fikTYQVw/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

0  libxul.so!mozilla::TaskQueue::Dispatch [TaskQueue.h:7b4edaa06578 : 68 + 0x0]
1  libxul.so!mozilla::MediaFormatReader::InputExhausted [MediaFormatReader.cpp:7b4edaa06578 : 2129 + 0x1] 

InputExhausted() is called after TaskQueue shutdown. I believe this is related to the remote decoding on Android.

Comment 2

[John Lin [:jhlin][:jolin]]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #1)
> InputExhausted() is called after TaskQueue shutdown. I believe this is
> related to the remote decoding on Android.

 Sounds like canceling the callback during Shutdown() [1] is not soon enough. Will add additional code to reject InputExhausted() as soon as input EOS is seen.

 [1] http://searchfox.org/mozilla-central/source/dom/media/platforms/android/RemoteDataDecoder.cpp#606

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1326238 - stop calling InputExhausted() once RemoteDataDecoder sends EOS input.

Review commit: https://reviewboard.mozilla.org/r/102854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102854/

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8824328 [details]
Bug 1326238 - stop calling InputExhausted() once RemoteDataDecoder sends EOS input.

https://reviewboard.mozilla.org/r/102854/#review104950

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ed09f5f1199
stop calling InputExhausted() once RemoteDataDecoder sends EOS input. r=snorp

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4ed09f5f1199