Closed Bug 1326288 Opened 7 years ago Closed 7 years ago

VP9 decoding broken by webrtc.org 49 update - YCbCr pointers are off

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- verified

People

(Reporter: ekr, Assigned: jesup)

References

Details

Attachments

(2 files)

Screen Shot 2016-12-29 at 12.42.41 PM.png
645.69 KB, image/png
Details
Restore patches for bug 1237023 and bug 1315283 - lost in 49 update
7.00 KB, patch
pkerr
: review+
Details | Diff | Splinter Review 
Seen on AppRTC
This is the video from Canary -> Firefox

I also see the same thing on Chrome Release -> Firefox.
Caused by the Webrtc 49 update.
pc_test.html has been updated to include a force-vp9 option which shows the problem.  The plane pointers for YCbCr on VP9 decode appear to be wrong.
Rank: 12
Depends on: 1250356
Priority: -- → P1
Summary: Severe visual artifacts on a call between Canary and Nightly → VP9 decoding broken by webrtc.org 49 update - YCbCr pointers are off
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Attachment #8822575 - Flags: review?(pkerr) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e548798fe7ce
Restore patches for bug 1237023 and bug 1315283 - lost in 49 update r=pkerr
Blocks: 1250356
No longer depends on: 1250356
https://hg.mozilla.org/mozilla-central/rev/e548798fe7ce
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
We'll cover this on Beta 53 through our WebRTC compatibility testing rounds. Setting ni? to myself as a reminder.
Flags: needinfo?(andrei.vaida)
I have reproduced the issue mentioned in comment 0 by following the steps mentioned in comment 1, using an affected Firefox 53.0a1 (Build Id:20161229030206) build. 

I have verified that the issue is not reproducible using Firefox 53.0b6 (Build Id:20170323090023) performing the following calls:
Windows 10 64bit (Firefox Beta) - Mac Os X 10.11.6 (Chrome Release).
Mac Os X 10.11.6 (Firefox Beta) – Windows 10 64bit (Chrome Release).
Ubuntu 16.04 64 bit (Firefox Beta). - Windows 10 64 bit (Chrome Release).
Windows 10 64bit (Firefox Beta) – Ubuntu 16.04 64bit (Chrome Release).
Mac Os X 10.11.6 (Firefox Beta) -Ubuntu 16.04 64 bit (Chrome Release).
Ubuntu 16.04 64bit (Firefox Beta) – Mac Os X 10.11.6 (Chrome Release).
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
Flags: needinfo?(andrei.vaida)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: