132697 - Supply "Stop" and "Send" buttons in Spell Checking dialog to support automatic spell checking when sending a mail message

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Charles Manske]

This was originally bugscape bug 3581.
1. Launch N6 [ or mozilla with spellchecker installed]
2. Click on the Mail icon from the Task Bar to launch Netscape Mail
3. Select Edit | Preferences
4. From the Prefrences window, select Mail and Newsgroups | Message Composition
5. From Message Composition, check the "Check spelling before sending" box
6. Click OK in the Prefrences window
7. From Mail window, click on New Message button
8. Compose a message with some incorrect words
9. Click on SEND

Results: You receive a Spell Check window, however, if you exit the dialogue by 
clicking on CLOSE or the X in the upper right corner, the message is sent.  

Note: This is not how 4.x worked. 4.x had a STOP button, and allowed the user to 
elect to STOP the Spell Check, and go back into the message to edit (Note:This 
is how Spell Check performs in 6.0 when you click on the Spell button).

Comment 1

[Charles Manske]

Attachment: Patch v3

This is identical to patch attached to bugscape 3581,
except Composer launches spelling dialog with the param
that signifies "spell check during send mail" action set false:
      window.openDialog("chrome://editor/content/EdSpellCheck.xul", "_blank",
	      "chrome,close,titlebar,modal", false);
Mail application should use this:
      window.openDialog("chrome://editor/content/EdSpellCheck.xul", "_blank",
	      "chrome,close,titlebar,modal", sendMode);
where "sendMode" is true when spell checking during send action.

Comment 2

[Charles Manske]

Comment on attachment 75506 [details] [diff] [review]
Patch v3

sr=hewitt

Comment 3

[andreww]

Comment on attachment 75506 [details] [diff] [review]
Patch v3

r=andreww - looks ok.

Comment 4

[Charles Manske]

*** Bug 83933 has been marked as a duplicate of this bug. ***

Comment 5

[Charles Manske]

*** Bug 132701 has been marked as a duplicate of this bug. ***

Comment 6

[David Einstein]

*** Bug 86296 has been marked as a duplicate of this bug. ***

Comment 7

[Aleksey Nogin]

Quick question - will "Send Later" work correctly with this patch? I haven't
tested this patch yet (I will), but when I tried the experimental patch from big
83933, "Send Later" would cause message to be sent right away after spellchecker...

Comment 8

[Charles Manske]

Aleksey: That would be totally dependent on what Varada does with the 
"window.cancelSendMessage" var the spell checker is closed.
So that is part of work that needs to be done in messagecompose.js and is not 
included in "Patch v3".

Comment 9

[varada]

I shall test the mailcompose part and attach a patch.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 75506 [details] [diff] [review]
Patch v3

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Charles Manske]

Comment on attachment 75506 [details] [diff] [review]
Patch v3

This was checked in.
Message composer code now needs to be fixed.

Comment 12

[Charles Manske]

Composer side is fixed. Message Composer needs to be changed as described in
comment #1.

Comment 13

[varada]

Attachment: MailCompose Portion of fix.

I tested SendLater and the spellchecker comes up and can be dismissed the same
way as for SendNow - either stop and edit or send. If send is chosen then it is
stored in the Unsent Messages folder. When we choose to send unsent messages it
is sent without any dialog - but we always have an option of going to that
folder and editing the message.

Comment 14

[Charles Manske]

Comment on attachment 75730 [details] [diff] [review]
MailCompose Portion of fix.

Since sendMode is always
true, you don't need to bother having a separate var, just use "true" in
openDialog with a comment to explain it.
I suggested that originally because I thought this was used by both "normal"
spell checking and just before send, but I now realize the former routes
through ComposerCommands.js.
r=cmanske with that change.

Comment 15

[David :Bienvenu]

Comment on attachment 75730 [details] [diff] [review]
MailCompose Portion of fix.

sr=bienvenu, IFF you make the change Charlie pointed out.

Comment 16

[varada]

Attachment: Patch V2

removed the var sendMode and invoked the function with just true.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 76105 [details] [diff] [review]
Patch V2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 18

[varada]

Marking Fixed.

Comment 19

[sujay]

Olga, please verify...thanks

Comment 20

[Aleksey Nogin]

Tested with BuildID 2002032603 on RedHat Linux 7.2, works great!

Comment 21

[Olga]

Verified on trunk recent builds, Win2K, Linux, MacOSX.