Closed Bug 1327962 Opened 7 years ago Closed 7 years ago

When I close suggestions, location bar sometimes fails to cancel/preserve "Switch to tab" items

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: arni2033, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted) 

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url in a new tab:  example.org/#Unique20160801003710
2. Open new tab, type/paste there "example.org/#Unique20160801003710"
3. Press Down key to select "Switch to tab" item, then Right key to hide suggestions
4. Press Enter.

AR:  example.org/#Unique20160728003708 loads in tab
ER:  Browser whould switch to tab from Step 1, as Right key in Step 3 should preserve "Switch to tab"


STR_2:  (difference in Step 4 and expectations)
1. Open url in a new tab:  example.org/#Unique20160801003710
2. Open new tab, type/paste there "example.org/#Unique20160801003710"
3. Press Down key to select "Switch to tab" item, then Escape key to cancel selection
4. Press Enter

AR:  Browser switches to tab from Step 1
ER:  example.org/#Unique20160728003708 should load in tab, as Escape restores typed/pasted value


Note:  also happens with short urls like https://vk.com/im
No longer blocks: 1277113
Component: Untriaged → Location Bar
I was able to reproduce the issue on latest FF release and latest Nightly. I will use mozregression to find a regression range for this issue.
I've used mozregression in order to find a regression range for this issue.
Here are my findings: 

Last good revision: be4ba3d5ca9a (2014-11-24)
First bad revision: 74edfbf0e6a3 (2014-11-25)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=be4ba3d5ca9a&tocha
nge=74edfbf0e6a3
Is this still reproducible on your end ? If yes, can you please retest this using latest FF release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ?
I'm wontfixing this, I think the behavior is ok, when the user presses right or left to close the popup, he may be want to edit the entry, and then it doesn't make sense to keep the switch-to-tab action. And there's no other valid reason to dismiss the popup before confirming. I think it's fine as-is.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.