Closed
Bug 1328408
Opened 7 years ago
Closed 7 years ago
make Sampler::GetRegisteredThreads not copy the registered threads list
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
5.09 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
We call GetRegisteredThreads repeatedly on the sampler thread whenever the profiler is active; there's no reason to have it churn memory.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8823417 -
Flags: review?(mstange)
Updated•7 years ago
|
Attachment #8823417 -
Flags: review?(mstange) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a27adae53f2 make Sampler::GetRegisteredThreads not copy the registered threads list; r=mstange
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2a27adae53f2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•