1328429 - When no redundant encodings are specified for RED in offer, do not output "empty" fmtp line for RED payload type in answer

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Michael Froman [:mjf]]

When receiving an offer with RED with no redundant encodings indicated, we output
a=ftmp:102

We should not output the fmtp line when there are no redundant encodings.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1328429 - don't output empty fmtp line when no redundant encodings are indicated for RED.

Review commit: https://reviewboard.mozilla.org/r/102684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102684/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8824134 [details]
Bug 1328429 - don't output empty fmtp line when no redundant encodings are indicated for RED.

https://reviewboard.mozilla.org/r/102684/#review103130

::: media/webrtc/signaling/gtest/jsep_session_unittest.cpp:3127
(Diff revision 1)
>            (dtmf_params);
>  
>    ASSERT_EQ("0-15", parsed_dtmf_params.dtmfTones);
>  }
>  
> +TEST_F(JsepSessionTest, VerifyNoFmtpForRedReceiveOnly)

The test name implies a recv only situation, but the test itself appears to be doing sendrecv in both directions. Can you adjust the test name?

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8824134 [details]
Bug 1328429 - don't output empty fmtp line when no redundant encodings are indicated for RED.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102684/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26e27966f5f0
don't output empty fmtp line when no redundant encodings are indicated for RED. r=drno

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/26e27966f5f0