Closed Bug 1328513 Opened 7 years ago Closed 7 years ago

stylo: fullscreen-related tests crash due to lack of -moz-top-layer support

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox53 --- affected

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

layout/style/test/chrome/test_display_mode.html
layout/style/test/chrome/test_display_mode_reflow.html
Nazim, got any cycles to add -moz-top-layer support?
Flags: needinfo?(canaltinova)
Note that -moz-top-layer is a property only available to ua sheet. Allowing web content to touch it would lead to breaking other assertions.
I tried to implement -moz-top-layer myself (since I implemented it for Gecko so more familiar with it). Then it seems the me those tests would continus crashing because of incorrect element state bits mapping.
Flags: needinfo?(canaltinova)
We also need to correct apply :fullscreen pseudo-class to have the -moz-top-layer property set.
Depends on: 1328806
https://github.com/servo/servo/pull/14857

But this is not enough. Servo also need to recognize :-moz-browser-frame pseudo-class to stop crashing fullscreen.
Depends on: 1329076
Assignee: nobody → xidorn+moz
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.