Closed Bug 1328795 Opened 7 years ago Closed 7 years ago

Enable some eslint rules that we are already passing

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

I've done a pass-through of our code and we have 0 errors for the following eslint rules:

no-extra-label = 0
no-iterator = 0
no-regex-spaces = 0
no-self-assign = 0
no-unsafe-negation = 0
no-unused-labels = 0

These can be enabled to prevent any future errors from occurring.
Comment on attachment 8823940 [details]
Bug 1328795 - Enable some eslint rules that we are already passing.

https://reviewboard.mozilla.org/r/102414/#review102978
Attachment #8823940 - Flags: review?(dtownsend) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a914b8b3f301
Enable some eslint rules that we are already passing. r=mossop
https://hg.mozilla.org/mozilla-central/rev/a914b8b3f301
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: