Closed
Bug 1328851
Opened 7 years ago
Closed 7 years ago
Enable eslint rule no-undef for storage/
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
This is part of the ongoing work to enable the no-undef eslint rule. The storage directory is quite easy to enable, mainly being just tests, so we should do that.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8824038 [details] Bug 1328851 - Enable eslint rule no-undef for storage/. https://reviewboard.mozilla.org/r/102560/#review102938 ::: storage/test/unit/test_statement_executeAsync.js:10 (Diff revision 1) > /* > * This file tests the functionality of mozIStorageBaseStatement::executeAsync > * for both mozIStorageStatement and mozIStorageAsyncStatement. > */ > > +// This file uses the intenal _quit from testing/xpcshell/head.js */ typo: intenal?
Attachment #8824038 -
Flags: review?(mak77) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8824038 [details] Bug 1328851 - Enable eslint rule no-undef for storage/. https://reviewboard.mozilla.org/r/102560/#review102938 > typo: intenal? Thanks for catching that, I somehow saw it but forgot to fix it.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c081650eddf Enable eslint rule no-undef for storage/. r=mak
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c081650eddf
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•