Closed Bug 1329124 Opened 7 years ago Closed 6 years ago

Figure out why (glob) is added at the end of the push message

Categories

(MozReview Graveyard :: Testing / Development Environment, defect)

Product:
MozReview Graveyard
Component:
Testing / Development Environment
Version:
Development/Staging
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: zalun, Unassigned, Mentored)

Details

According to [1]:

Lines ending with a space and the keyword (glob) are matched with a glob-like syntax. The only special characters supported are "*" and "?". Both characters can be escaped using "\", and the backslash can be escaped itself.

In our tests it looks similar to:

    hg push
    pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
    (adding commit id to 1 changesets)
      saved backup bundle to $TESTTMP/client/.hg/strip-backup/8d901902ff4b-c4c7c89c-addcommitid.hg (glob)

A lot of tests are affected.

[1] https://www.mercurial-scm.org/wiki/WritingTests#Format_summary
A Mercurial release several months ago (over a year I think) changed the backup bundle filename. So for a time we needed to glob over the hash part in the message so the tests would pass on old and new Mercurial versions.

At this point, I'm pretty sure we can drop the (glob) from these messages as all the Mercurial versions we support use the new filename / message.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.