1329234 - Remove last uses of Scoped.h from PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

PSM is almost free from uses of Scoped.h.

The only things left are in ScopedNSSTypes.h as the ScopedX NSS types, and the only consumer left is in ipc/keystore/, which is B2G specific.

We should rip out the entire ipc/keystore/ folder since we don't need to keep B2G code in m-c anymore, and rid PSM of Scoped.h entirely.

Comment 1

[:Cykesiopka]

Attachment: Bug 1329234 - Remove ipc/keystore/.

This folder only contains B2G specific code, which we can now remove from m-c.
Moreover, it is the last consumer of the Scoped.h NSS types provided by
ScopedNSSTypes.h, so removing the folder makes getting rid of Scoped.h easier.

Review commit: https://reviewboard.mozilla.org/r/103924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103924/

Comment 2

[:Cykesiopka]

Attachment: Bug 1329234 - Remove last uses of Scoped.h from PSM.

Existing code has already switched to the UniqueX NSS types.

Review commit: https://reviewboard.mozilla.org/r/103926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103926/

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8825856 [details]
Bug 1329234 - Remove ipc/keystore/.

https://reviewboard.mozilla.org/r/103924/#review104766

Comment 4

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8825857 [details]
Bug 1329234 - Remove last uses of Scoped.h from PSM.

https://reviewboard.mozilla.org/r/103926/#review105226

Comment 5

[:Cykesiopka]

Thanks for the reviews!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=344278117bb434cc677feb9bd0991b89bedd24fb
The failures look like intermittents.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67e09570f10a
Remove ipc/keystore/. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/4a234901b459
Remove last uses of Scoped.h from PSM. r=mgoodwin

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67e09570f10a
https://hg.mozilla.org/mozilla-central/rev/4a234901b459