Closed
Bug 1329466
Opened 7 years ago
Closed 7 years ago
toolkit/components/terminator/nsTerminator.cpp:218:67: error: 'AutoProfilerRegister::AutoProfilerRegister(const char*)' is private within this context (non-SPS)
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | fixed |
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Keywords: regression, Whiteboard: [npotb])
Attachments
(1 file)
toolkit/components/terminator/nsTerminator.cpp:218:24: error: calling a private constructor of class 'AutoProfilerRegister' AutoProfilerRegister registerThread("Shutdown Statistics Writer"); ^ objdir/dist/include/GeckoProfiler.h:251:3: note: implicitly declared private here AutoProfilerRegister(const char* aName) {} ^ 1 error generated.
In file included from objdir/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:101: ipc/chromium/src/base/thread.cc:156:32: error: expected ';' after expression mozilla::AutoProfilerRegister registerThread(name_.c_str()); ^ ; ipc/chromium/src/base/thread.cc:156:12: error: no member named 'AutoProfilerRegister' in namespace 'mozilla' mozilla::AutoProfilerRegister registerThread(name_.c_str()); ~~~~~~~~~^ ipc/chromium/src/base/thread.cc:156:33: error: use of undeclared identifier 'registerThread' mozilla::AutoProfilerRegister registerThread(name_.c_str()); ^ 3 errors generated.
In file included from objdir/js/xpconnect/src/Unified_cpp_js_xpconnect_src0.cpp:56: js/xpconnect/src/XPCJSContext.cpp:1169:34: error: expected ';' after expression mozilla::AutoProfilerRegister registerThread("JS Watchdog"); ^ ; js/xpconnect/src/XPCJSContext.cpp:1169:14: error: no member named 'AutoProfilerRegister' in namespace 'mozilla' mozilla::AutoProfilerRegister registerThread("JS Watchdog"); ~~~~~~~~~^ js/xpconnect/src/XPCJSContext.cpp:1169:35: error: use of undeclared identifier 'registerThread' mozilla::AutoProfilerRegister registerThread("JS Watchdog"); ^ 3 errors generated.
Comment hidden (mozreview-request) |
comment 0 reproduced on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7180da60601039a88f569e38b285fbf90fde5d6e
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8824759 [details] Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100. https://reviewboard.mozilla.org/r/103078/#review103672
Attachment #8824759 -
Flags: review?(mstange) → review+
Comment on attachment 8824759 [details] Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100. https://reviewboard.mozilla.org/r/103078/#review103682 ::: tools/profiler/public/GeckoProfiler.h:254 (Diff revision 1) > +namespace mozilla { > + > class AutoProfilerRegister final MOZ_STACK_CLASS > { > +public: > AutoProfilerRegister(const char* aName) {} The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here?
Comment 7•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8824759 [details] Bug 1329466 - Unbreak build on non-SPS platforms after bug 1323100. https://reviewboard.mozilla.org/r/103078/#review103682 > The constructor is `explicit` in GeckoProfilerImpl.h. Should I mark it the same here? Oh, yes please.
Comment hidden (mozreview-request) |
Keywords: checkin-needed
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/51c898702340 Unbreak build on non-SPS platforms after bug 1323100. r=mstange
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/51c898702340
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•7 years ago
|
Assignee: nobody → jbeich
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•