1329538 - Make Adobe Primetime CDM non-visible in Firefox

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Henceforth we will no longer be shipping Adobe Primetime support in Firefox.

So we should flip the pref to make it not appear by default in the add-on manager plug-in list, and thus render it invisible and disabled by default.

The Adobe Primetime CDM was already not being downloaded by default (bug 1304899).

I will follow up in other bugs to remove the supporting code.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c5a02abd91d388cfa71b84a9351b2c5046ff7d5

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1329538 - Don't enable Adobe EME in release mozconfig.

Review commit: https://reviewboard.mozilla.org/r/103116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103116/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

We'll want to uplift this to Firefox 52, as that's what's becoming ESR.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8824836 [details]
Bug 1329538 - Don't enable Adobe EME in release mozconfig.

https://reviewboard.mozilla.org/r/103116/#review104068

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800cdcd929ed
Don't enable Adobe EME in release mozconfig. r=glandium

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/800cdcd929ed

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8824836 [details]
Bug 1329538 - Don't enable Adobe EME in release mozconfig.

We are removing Adobe Primetime EME support, and it's already disabled by default in 52.


Approval Request Comment
[Feature/Bug causing the regression]: Adobe Primetime EME support

[User impact if declined]: We'll show the Primetime EME CDM in the add-ons manager, disabled by default. We expect the download server for the Primetime CDM to stop working sometime soon, so we want to remove it from Firefox before 52 hits ESR, so we don't get stuck with a CDM we can't download in our add-ons UI for a year in ESR52.

[Is this code covered by automated tests?]: We have lots of EME mochitests. We have external-media-tests that verify that Netflix is not affected.

[Has the fix been verified in Nightly?]: I verified it this morning.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: This patch removes enabling Primetime EME in our Windows build config, so it's not enabled just like on Mac/Linux already. So this is low risk, as this code path is well tested on our other platforms.

[String changes made/needed]: None.

Comment 8

[Gerry Chang [:gchang]]

Hi :cpearce,
According to comment #3, it seems to me that we only want this in 52, right? Since beta is 51 now, is it ok that we won't fix this in Beta51?

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8824836 [details]
Bug 1329538 - Don't enable Adobe EME in release mozconfig.

disable adobe eme for aurora52

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/30623e5f26ae

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Gerry Chang [:gchang] from comment #8)
> Hi :cpearce,
> According to comment #3, it seems to me that we only want this in 52, right?
> Since beta is 51 now, is it ok that we won't fix this in Beta51?

We can let it ride in 52. I was off by one and mistakenly thought that 52 was currently in beta. So just uplifting to aurora 52 is fine.