13300 - MLK: nsProfile::GetSingleProfile()

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P3)

Description

[Bruce Mitchener]

rv = enumKeys->CurrentItem( &base );

That allocates an object.  Please free!

This code really needs more serious review I suspect.  This is the 3rd leak so
far tonight.

[W] MLK: Memory leak of 2064 bytes from 1 block allocated in
nsRegSubtreeEnumerator::CurrentItem(nsISupports * *)
        Distribution of leaked blocks
              2064 bytes from 1 block of 2064 bytes (0x03743198) allocation
number 28905
        Allocation location
            new(UINT)      [new.cpp:23]
            nsRegSubtreeEnumerator::CurrentItem(nsISupports * *)
[nsRegistry.cpp:1092]
            nsProfile::GetSingleProfile(char * *) [nsProfile.cpp:613]
            GetProfileDirectory [nsFileLocations.cpp:101]
            nsSpecialFileSpec::=(Type::nsSpecialFileSpec)
[nsFileLocations.cpp:299]
            nsSpecialFileSpec::nsSpecialFileSpec(Type::nsSpecialFileSpec)
[nsFileLocations.cpp:225]
            nsSpecialFileSpec::=(Type::nsSpecialFileSpec)
[nsFileLocations.cpp:248]
            nsSpecialFileSpec::nsSpecialFileSpec(Type::nsSpecialFileSpec)
[nsFileLocations.cpp:225]
            nsSpecialFileSpec::=(Type::nsSpecialFileSpec)
[nsFileLocations.cpp:346]
            nsFileLocator::GetFileLocation(UINT,nsIFileSpec * *)
[nsFileLocations.cpp:466]
            NS_LocateFileOrDirectory(UINT) [nsIFileLocator.h:61]
            nsPref::useDefaultPrefFile(void) [nsPref.cpp:164]
            nsPref::ReadUserPrefs(void) [nsPref.cpp:297]
            nsPrefProfile::Startup(nsICmdLineService *) [nsAppRunner.cpp:637]
            main1          [nsAppRunner.cpp:798]

Comment 1

[racham]

Will use nsCRT::free(). Changing status to assigned.

Comment 2

[Alec Flett]

Taking all these bugs to be fixed appropriately.

Comment 3

[Alec Flett]

racham, fixing this for you.
You don't free nsISupports objects with nsCRT::free.
Please look at my changes to learn how to use nsCOMPtr

Comment 4

[Grace Bush]

dev bug

Comment 5

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a378387c3c14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13300 - Adjust the 'Sharing a Collection' layout to prevent overlapping of the close icon and 'Share' label in RTL