Closed Bug 1330117 Opened 7 years ago Closed 7 years ago

Put all section titles in Title Case

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- verified

People

(Reporter: mconley, Assigned: herrickz, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.
59 bytes, text/x-review-board-request
jaws
: review+
Details
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.
59 bytes, text/x-review-board-request
jaws
: review-
Details 
From Slide 26 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509

Titles in Preferences, like "DRM content", should be in Title Case, like "DRM Content".
Assignee: nobody → herrickz
Mentor: mconley, jaws
Status: NEW → ASSIGNED
Comment on attachment 8829666 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/106670/#review107994

Hey Zach, thanks for the patch!

Great start here - but I think there are a few more sections that need to be updated, for example:

In Search: "One-click search engines" should be "One-click Search Engines"
In Sync: "Sync across all devices" should be "Sync Across All Devices"

There are a few under "Advanced" as well.

If you're unsure of which words to capitalize, http://titlecapitalization.com/ is probably a fine guide.

::: browser/locales/en-US/chrome/browser/preferences/content.dtd:56
(Diff revision 1)
>    -  browser/translation.dtd
>    -->
>  <!ENTITY translation.options.attribution.beforeLogo "Translations by">
>  <!ENTITY translation.options.attribution.afterLogo "">
>  
> -<!ENTITY  drmContent.label             "DRM content">
> +<!ENTITY  drmContent.label             "DRM Content">

Due to the way that our localization tools currently work, when we update a string like this, we have to update the key as well. The current convention is to increment a counter at the end of the key. So this should be something like:

`<!ENTITY  drmContent.label2             "DRM Content">`

and then you'll need to update the referenec to `drmContent.label` and change it to `drmContent.label2` in the XHTML file.
Attachment #8829666 - Flags: review?(mconley) → review-
(In reply to Mike Conley (:mconley) from comment #2)
> Due to the way that our localization tools currently work, when we update a
> string like this, we have to update the key as well. The current convention
> is to increment a counter at the end of the key. So this should be something
> like:
> 
> `<!ENTITY  drmContent.label2             "DRM Content">`
> 
> and then you'll need to update the referenec to `drmContent.label` and
> change it to `drmContent.label2` in the XHTML file.

Minor correction, the increment should go before the period. And if there is an associated accesskey then it should be updated too. This would be drmContent2.label / drmContent2.accesskey. It's important that the .label and .accesskey remain consistent with each other.

However, I'm not sure we need to rev the IDs with just the casing change. Axel, what do you think?
Flags: needinfo?(community)
Changing the string without updating the ID is fine in these cases: each locale is supposed to have its own set of rules regarding case. Also, a lot of languages don't even have the concept of Title Case (e.g. Italian), some don't even have uppercase.

P.S. :l10n is a bunch of localizers, :pike is Axel. I'm also the right point of contact for these questions ;-)
Flags: needinfo?(community)
Comment on attachment 8829666 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/106670/#review108418

Looks pretty good - but I think we've missed one. Thanks!

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:93
(Diff revision 2)
>  <!ENTITY welcome.signIn.label "Sign In">
>  <!ENTITY welcome.createAccount.label "Create Account">
>  
>  <!ENTITY welcome.useOldSync.label "Using an older version of Sync?">
>  
>  <!ENTITY signedOut.caption            "Take your Web with you">

What about this one? I think this should probably be "Take Your Web with You".
Attachment #8829666 - Flags: review?(mconley) → review-
Comment on attachment 8829666 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/106670/#review108654

Please update the commit message to "Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency. r?jaws"

Also, please visit the MozReview page[1] and mark the issue "fixed" that mconley pointed out. 

[1] https://reviewboard.mozilla.org/r/106670/
Attachment #8829666 - Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab540f0d551b
Change section headers in Preferences to use Capital Case for consistency. r=jaws
https://hg.mozilla.org/mozilla-central/rev/ab540f0d551b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8850080 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/122806/#review124992

::: browser/locales/en-US/chrome/browser/preferences/advanced.dtd:117
(Diff revision 1)
>  <!ENTITY offlineAppsList.height          "7em">
>  <!ENTITY offlineAppsListRemove.label     "Remove…">
>  <!ENTITY offlineAppsListRemove.accesskey "R">
>  <!ENTITY offlineAppRemove.confirm        "Remove offline data">
>  
> -<!ENTITY certificateTab.label            "Certificates">
> +<!ENTITY certPersonal.label              "Certificates">

You need a different string ID here.

certPersonal.label was already in the file and set to "Requests", this is equivalent to an unwanted string change

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:18
(Diff revision 1)
>  <!ENTITY  trackingProtectionExceptions.label   "Exceptions…">
>  <!ENTITY  trackingProtectionExceptions.accesskey "x">
>  
>  <!ENTITY tracking.label                 "Tracking">
> -<!ENTITY trackingProtectionPBM5.label         "Use Tracking Protection in Private Windows">
> +<!ENTITY trackingProtectionPBM6.label         "Tracking Protection">
>  <!ENTITY trackingProtectionPBM5.accesskey     "v">

Please change also the accesskey ID accordingly to the associated label.

::: browser/locales/en-US/chrome/browser/preferences/security.dtd:30
(Diff revision 1)
>  
>  
> -<!ENTITY  logins.label                  "Logins">
> +<!ENTITY  formsAndPasswords.label       "Forms &amp; Passwords">
>  
> -<!ENTITY  rememberLogins.label          "Remember logins for sites">
> +<!ENTITY  rememberLogins1.label          "Remember logins and passwords for sites">
>  <!ENTITY  rememberLogins.accesskey      "R">

Same here, update also the associated accesskey ID
Comment on attachment 8850080 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/122806/#review124998

Did a second pass and found another couple of issues, plus a question about "logins".

::: browser/locales/en-US/chrome/browser/preferences/preferences.dtd:26
(Diff revision 1)
> -<!ENTITY  panePrivacy.title       "Privacy">
> -<!ENTITY  paneContainers.title    "Container Tabs">
> -<!ENTITY  paneSecurity.title      "Security">
> -<!ENTITY  paneAdvanced.title      "Advanced">
> +<!ENTITY  panePrivacySecurity.title     "Privacy &amp; Security">
> +<!ENTITY  paneContainers.title          "Container Tabs">
> +<!ENTITY  paneSecurity.title            "Security">
> +<!ENTITY  paneUpdates.title             "Updates">
>  
> -<!-- LOCALIZATION NOTE (paneSync.title): This should match syncBrand.shortName.label in ../syncBrand.dtd -->
> +<!-- LOCALIZATION NOTE (paneSync1.title): This should match syncBrand.shortName.label in ../syncBrand.dtd -->

This comment is not relevant anymore. You probably want "match syncBrand.fxAccount.label".

https://hg.mozilla.org/mozilla-central/file/default/browser/locales/en-US/chrome/browser/syncBrand.dtd

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:18
(Diff revision 1)
>  <!ENTITY  trackingProtectionExceptions.label   "Exceptions…">
>  <!ENTITY  trackingProtectionExceptions.accesskey "x">
>  
>  <!ENTITY tracking.label                 "Tracking">
> -<!ENTITY trackingProtectionPBM5.label         "Use Tracking Protection in Private Windows">
> +<!ENTITY trackingProtectionPBM6.label         "Tracking Protection">
>  <!ENTITY trackingProtectionPBM5.accesskey     "v">

One more note: you shouldn't use v as an accesskey, it's not available in "Tracking Protection".

::: browser/locales/en-US/chrome/browser/preferences/security.dtd:29
(Diff revision 1)
>  <!ENTITY  addonExceptions.accesskey     "E">
>  
>  
> -<!ENTITY  logins.label                  "Logins">
> +<!ENTITY  formsAndPasswords.label       "Forms &amp; Passwords">
>  
> -<!ENTITY  rememberLogins.label          "Remember logins for sites">
> +<!ENTITY  rememberLogins1.label          "Remember logins and passwords for sites">

I'm confused by this string: isn't login supposed to include both user and password?
Comment on attachment 8850080 [details]
Bug 1330117 - Change section headers in Preferences to use Capital Case for consistency.

https://reviewboard.mozilla.org/r/122806/#review125018

This bug is closed. I think this patch was incorrectly pushed to this bug.
Attachment #8850080 - Flags: review?(jaws) → review-
Verified fixed on Windows 7 x64, Ubuntu 16.04 x64 and Mac OS X 10.11 using latest Aurora 54.0a2 (2017-04-10; en-US build).
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: