Closed
Bug 1330196
Opened 7 years ago
Closed 7 years ago
[jsplugins] Can not render pdf with latest PDFium binary
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: lochang, Assigned: lochang)
References
Details
Attachments
(1 file)
1.28 KB,
patch
|
brsun
:
review+
|
Details | Diff | Splinter Review |
We can not normally render the pdf with the latest PDFium binary. The page is blank but UI is still there. We should dig into the problem see if there is anything we can fix in runtime.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → lochang
Assignee | ||
Comment 1•7 years ago
|
||
We can not normally render the pdf with the PDFium binary which is built after 2016, Nov 15.
Assignee | ||
Comment 2•7 years ago
|
||
Hi Bruce, Would you please review the patch? The patch fixes the rendering problem with latest PDFium binary. Recently, Chromium improves pinch-zoom for PDF [1]. PostMessage of type viewport takes an addition parameter pinchPhase. We workaround here by adding a pinchPhase of value 0 to make sure that viewing pdf works normally. [1] Chromium revision: 6e1abbfb2450eedddb1ab128be1b31cc93104e41
Attachment #8835446 -
Flags: review?(brsun)
Comment 3•7 years ago
|
||
Comment on attachment 8835446 [details] [diff] [review] Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun Review of attachment 8835446 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8835446 -
Flags: review?(brsun) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Attachment #8835446 -
Attachment description: Bug 1330196 - Can not render pdf with latest PDFium binary → Bug 1330196 - Can not render pdf with latest PDFium binary, r=brsun
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/80e155870904fbec43dfe981077df3475e0d2c87 Bug 1330196 - Can not render pdf with latest PDFium binary. r=brsun
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=80e155870904fbec43dfe981077df3475e0d2c87
Updated•7 years ago
|
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/80e155870904
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in
before you can comment on or make changes to this bug.
Description
•