1330998 - NPAPI plugins can still be enabled in Nightly 53

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Paul Silaghi, QA [:pauly]]

[Affected versions]:
- 52, 53

[Affected platforms]:
- all

[Steps to reproduce]:
1. Open FX 50.1.0 release with a new profile
2. In about:config create "plugin.load_flash_only=FALSE"
3. Start latest nightly using the same profile
4. Open about:addons / plugins -> NPAPI plugins enabled
5. Set "plugin.load_flash_only=TRUE"

[Expected result]:
- NPAPI plugins disabled

[Actual result]:
- NPAPI plugins enabled

[Regression range]:
- not sure if this is a regression or not

Comment 1

[Benjamin Smedberg]

This is not a regression. It's also basically expected behavior. This "pref" is not designed to be flipped by users; it's designed to only be flipped as part of the config.

The only time this might continue to be a real issue is if somebody is switching back and forth between ESR and release, and therefore has a stale pluginreg file.  I'm not sure that's worth fixing.

Comment 2

[Chris Peterson [:cpeterson]]

After setting the plugin.load_flash_only pref, you need to manually delete the %USERPROFILE%\AppData\Mozilla\Firefox\Profiles\YOUR-PROFILE-NAME-HERE\pluginreg.dat file because it is caching the old plugin list.

Can you please confirm that the following upgrade scenario works correctly? This simulates the upgrade that ESR 52 users will see.

1. Create new user profile using an old Aurora *51* build:
http://ftp.mozilla.org/pub/firefox/nightly/2016/11/2016-11-13-00-40-06-mozilla-aurora/
2. Confirm that about:addons and about:plugins show all your plugins.
3. Create the plugin.load_flash_only pref = FALSE.
4. Open Aurora 51's Help -> About box to force an update to the latest Aurora 52.
5. Restart Aurora to version 52.
6. Do about:addons and about:plugins still show all your plugins? If not, that is a bug!

Comment 3

[Paul Silaghi, QA [:pauly]]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> 6. Do about:addons and about:plugins still show all your plugins? If not,
> that is a bug!
All plugins are displayed after update. About:plugins also displays the "Missing something? Some plugins are no longer supported" notification.
Setting "plugin.load_flash_only=TRUE" shows all plugins + about:plugins "missing" notification + about:addons "missing" notification.

Comment 4

[Chris Peterson [:cpeterson]]

Thanks for checking, Paul. So I believe comment 0 is expected behavior and not a bug.

Comment 5

[Benjamin Smedberg]

I'm going to reopen this as I figured out a simple way to fix this on restart, so people switching between release and ESR get the correct config.

Comment 6

[Benjamin Smedberg]

Attachment: Bug 1330998 - Invalidate pluginreg.dat based on whether the flash-only pref is flipped, so that if users switch between 52 and 52ESR it gets updated correctly.

Review commit: https://reviewboard.mozilla.org/r/105206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105206/

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8827568 [details]
Bug 1330998 - Invalidate pluginreg.dat based on whether the flash-only pref is flipped, so that if users switch between 52 and 52ESR it gets updated correctly.

https://reviewboard.mozilla.org/r/105206/#review106024

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbdef7fdc1c6
Invalidate pluginreg.dat based on whether the flash-only pref is flipped, so that if users switch between 52 and 52ESR it gets updated correctly. r=qdot

Comment 9

[Benjamin Smedberg]

Tracking note: This will improve ESR52 experience.

Comment 10

[Benjamin Smedberg]

Comment on attachment 8827568 [details]
Bug 1330998 - Invalidate pluginreg.dat based on whether the flash-only pref is flipped, so that if users switch between 52 and 52ESR it gets updated correctly.

Approval Request Comment
[Feature/Bug causing the regression]: 1269807 - feature to enable only Flash
[User impact if declined]: Users switching between ESR and non-ESR may not see the expected plugin configuration
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: STR in bug
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: I don't think so; it invalidates a cache. In the worst case bug, we'd load fresh at each startup which is not a big deal.
[String changes made/needed]:None

Comment 11

[Benjamin Smedberg]

Stefan or Paul, can one of you please test and verify?

Comment 12

[Paul Silaghi, QA [:pauly]]

Awesome! Verified fixed latest 53 inbound build - https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32/1484723366/

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbdef7fdc1c6

Comment 14

[Marcia Knous [:marcia]]

Tracking 52/53+ to improve the ESR experience.

Comment 15

[Masatoshi Kimura [:emk]]

Shouldn't we remove "plugin.load_flash_only" and hard-code 't' in pluginreg.dat on 53? The fix is something other than what the bug summary says.

Comment 16

[Benjamin Smedberg]

Removing the load_flash_only pref will be done in a separate followup patch once a couple of product questions/dependencies are done.

Comment 17

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8827568 [details]
Bug 1330998 - Invalidate pluginreg.dat based on whether the flash-only pref is flipped, so that if users switch between 52 and 52ESR it gets updated correctly.

handle flash-only pref flipping, aurora52+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9bb207f947d8

Comment 19

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 52b5, 53.0a2 (2017-02-10) Win 7.