Open
Bug 1331122
Opened 7 years ago
Updated 2 years ago
Intermittent devtools/client/framework/test/browser_toolbox_races.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Categories
(DevTools :: Framework, defect, P3)
DevTools
Framework
Tracking
(Not tracked)
REOPENED
Firefox 55
People
(Reporter: intermittent-bug-filer, Assigned: ochameau)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=68924167&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64-debug/1484338943/mozilla-inbound_win8_64-debug_test-mochitest-e10s-devtools-chrome-2-bm127-tests1-windows-build84.txt.gz
Priority: -- → P3
See Also: → 1330805
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 2•7 years ago
|
||
We're seeing this test fail consistently in a code coverage build in e10s mode (https://treeherder.mozilla.org/#/jobs?repo=try&revision=e00b3e11f7ef1e7b3190b2d05ad2c831799f4df2&selectedJob=94062273). Would increasing the timeout fix the problem? From my limited understanding, the test seems a little brittle.
Flags: needinfo?(jryans)
I'll defer to :ochameau who added the test.
Flags: needinfo?(jryans) → needinfo?(poirot.alex)
|
Assignee | |
Comment 4•7 years ago
|
||
It fails after the test finishes, so during test harness teardown. So yes, most likely a timeout issue.
Flags: needinfo?(poirot.alex)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → poirot.alex
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8861529 [details] Bug 1331122 - Increase test timeout for browser_toolbox_races. https://reviewboard.mozilla.org/r/133498/#review136706 Indeed, even when successful the test takes between 75s and 90s, so already close to the timeout threshold with requestLongerTimeout(1).
Attachment #8861529 -
Flags: review?(jdescottes) → review+
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b0285d6f358 Increase test timeout for browser_toolbox_races. r=jdescottes
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3b0285d6f358
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
| Comment hidden (Intermittent Failures Robot) |
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(poirot.alex)
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 13•6 years ago
|
||
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=153224139&repo=mozilla-esr52&lineNumber=2151 [task 2017-12-23T20:26:05.121337Z] 20:26:05 INFO - TEST-START | devtools/client/framework/test/browser_toolbox_races.js [task 2017-12-23T20:27:40.925667Z] 20:27:40 INFO - TEST-INFO | started process screentopng [task 2017-12-23T20:27:42.992766Z] 20:27:42 INFO - TEST-INFO | screentopng: exit 0 [task 2017-12-23T20:27:42.997011Z] 20:27:42 INFO - Buffered messages logged at 20:26:05 [task 2017-12-23T20:27:43.000132Z] 20:27:42 INFO - Entering test bound [task 2017-12-23T20:27:43.003498Z] 20:27:43 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,Toggling devtools quickly [task 2017-12-23T20:27:43.008117Z] 20:27:43 INFO - Tab added and finished loading [task 2017-12-23T20:27:43.010916Z] 20:27:43 INFO - Trying to toggle the toolbox 3 times [task 2017-12-23T20:27:43.015567Z] 20:27:43 INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 776}] [task 2017-12-23T20:27:43.020061Z] 20:27:43 INFO - Buffered messages logged at 20:27:33 [task 2017-12-23T20:27:43.022654Z] 20:27:43 INFO - Toggled the toolbox 3 times [task 2017-12-23T20:27:43.025223Z] 20:27:43 INFO - Buffered messages logged at 20:27:40 [task 2017-12-23T20:27:43.033774Z] 20:27:43 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_races.js | right number of created events - [task 2017-12-23T20:27:43.037511Z] 20:27:43 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_races.js | right number of ready events - [task 2017-12-23T20:27:43.040562Z] 20:27:43 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_races.js | right number of destroy events - [task 2017-12-23T20:27:43.043756Z] 20:27:43 INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_races.js | right number of destroyed events - [task 2017-12-23T20:27:43.049597Z] 20:27:43 INFO - Leaving test bound [task 2017-12-23T20:27:43.052151Z] 20:27:43 INFO - Buffered messages finished [task 2017-12-23T20:27:43.057620Z] 20:27:43 INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_races.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - [task 2017-12-23T20:27:43.061838Z] 20:27:43 INFO - MEMORY STAT | vsize 20973873MB | residentFast 889MB [task 2017-12-23T20:27:43.064459Z] 20:27:43 INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_races.js | took 95820ms [task 2017-12-23T20:27:43.066865Z] 20:27:43 INFO - checking window state
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•2 years ago
|
Severity: normal → S3
status-firefox55:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•