Closed Bug 1331255 Opened 7 years ago Closed 7 years ago

Crash in IPCError-browser | PDocAccessibleParent::RecvBindChildDoc

Categories

(Core :: Disability Access APIs, defect)

Unspecified
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: marcia, Assigned: tbsaunde)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-784809ae-83b3-418c-a18e-f20a62170115.
=============================================================

Seen while looking at nightly crash stats: http://bit.ly/2iufOs1

Crashes started in 20170114030206 build.  Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=91f5293e9a89056565493ed5073c3842b0ee9fdc&tochange=ac3275723df59db0f09198fdb61b51e7002c391a
#4 topcrash in Nightly 20170113030227, with 53 occurrences.

davidb, it's another a11y crash.
Flags: needinfo?(dbolter)
Component: Layout → Disability Access APIs
Flags: needinfo?(dbolter)
Comment on attachment 8828098 [details] [diff] [review]
annotate some IPC failure conditions

Review of attachment 8828098 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming this is just to put in some probes for a followup fix?

Looks good. One query below. Thanks for sending reviews my way. Trying to catch up..

::: accessible/ipc/DocAccessibleParent.cpp
@@ +378,5 @@
>  
>    MOZ_DIAGNOSTIC_ASSERT(CheckDocTree());
>  
>    auto childDoc = static_cast<DocAccessibleParent*>(aChildDoc);
>    childDoc->Unbind();

Any chance aChildDoc is null? Dereferencing it here can also be causing a crash. No?
Attachment #8828098 - Flags: review?(eitan) → review+
> ::: accessible/ipc/DocAccessibleParent.cpp
> @@ +378,5 @@
> >  
> >    MOZ_DIAGNOSTIC_ASSERT(CheckDocTree());
> >  
> >    auto childDoc = static_cast<DocAccessibleParent*>(aChildDoc);
> >    childDoc->Unbind();
> 
> Any chance aChildDoc is null? Dereferencing it here can also be causing a
> crash. No?

no, ipdl wants you to mark actor arguments as nullable if they can be null and this one isn't.  In any case that would be invalid for the child to send, and I don't think I've ever seen a crash there.
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e28612e9fdb8
annotate some IPC failure conditions r=eeejay
https://hg.mozilla.org/mozilla-central/rev/e28612e9fdb8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 1332690 shows a more informative crash.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → DUPLICATE
Per comment #6, other issues and followups should be tracked in new bugs.
Resolution: DUPLICATE → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: