1331263 - Browser debugger state gets confused

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[:Gijs (he/him)]

STR:

1. nightly Jan. 15, enable browser toolbox
2. open addons manager
3. open browser toolbox
4. set breakpoint in AddonManager.jsm on the first line of getPrefferedIconURL
5. switch to 'appearance' tab (or switch away and back to the appearance tab
6. hit continue a few times

ER:
don't get stuck

AR:
at some point the debugger believes it's paused (continue button highlights blue, OS X icon overlay shows pause status) but also that it's not (no current line highlight, continue/step buttons all do nothing when clicked). The main browser does not respond to input. The only way to restore normalcy is quitting the browser devtools process.

Comment 1

[:Gijs (he/him)]

OK, that doesn't seem to be enough to reliably reproduce this. Better steps:

0. nightly Jan. 15, clean profile, enable browser toolbox, open add-on manager, switch to 'appearance', enable dark compact theme
1. restart with the same profile, dismiss default browser prompt if it shows up.
2. open addons manager again (I used restore prev. session, probably doesn't matter)
3. open browser toolbox via cmd-opt-shift-i (or Windows/Linux equiv.). accept connection prompt.
4. switch to debugger, set breakpoint in AddonManager.jsm on the first line of getPrefferedIconURL (2360).
5. in the browser, switch away and back to the appearance tab
6. the breakpoint will hit. Add these 3 watches:

aAddon.id
aAddon.icons
aAddon.iconURL

7. hit continue a few times

ER:
don't get stuck

AR:
at some point the debugger believes it's paused (continue button highlights, OS X icon overlay shows pause status, if you switch to another devtools tab the debugger tab highlights) but also that it's not (no current line highlight, continue/step buttons all do nothing when clicked, locals are not displayed and watches view displays nothing for any of the watches). The main browser does not respond to input. The only way to restore normalcy is quitting the browser devtools process.

Full console output in the browser toolbox:

DebuggeeWouldRun: debuggee `resource://gre/modules/commonjs/toolkit/loader.js:748' would run  builtin-modules.js:152:11
DebuggeeWouldRun: debuggee `resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:736' would run  script.js:350:5
DebuggeeWouldRun: debuggee `resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:736' would run script.js:350:5
DebuggeeWouldRun: debuggee `self-hosted:3162' would run  object.js:1031:20

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

I wasn't able to reproduce this anymore but will continue tracking this here: https://github.com/devtools-html/debugger.html/issues/3406

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

This appears to be fixed now, tracking any other fallout issues from the GH issue.