Closed Bug 133140 Opened 22 years ago Closed 22 years ago

[HAVE REVIEW] ctcpSend is using 'from' not 'target'

Categories

(Webtools Graveyard :: Mozbot, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ian, Assigned: ian)

Details

There is a bug in ctcpSend. It should use $event->{'target'} not $event->{'from'}.

The patch:

 sub ctcpSend {
     my $self = shift;
     my ($event, $type, $data) = @_;
-    &::sendmsg($event->{'bot'}, $event->{'from'}, [$type, $data], 'ctcpSend');
+    &::sendmsg($event->{'bot'}, $event->{'target'}, [$type, $data],'ctcpSend');
 }

Makes ctcpSend() send messages to the target, not the originator. This makes it
work like say().
This was caught by Cosmic[]shamE on #mozwebtools.
Status: NEW → ASSIGNED
Keywords: review
Priority: -- → P1
Target Milestone: --- → Mozbot 2.4
Keywords: review
Summary: [HAVE FIX] ctcpSend is using 'from' not 'target' → [HAVE REVIEW] ctcpSend is using 'from' not 'target'
QA Contact: timeless → kerz
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: kerz → mozbot
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.