1331467 - Turn on chrome.storage.sync by default

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Andy McKay]

The testing has been completed and things are looking good. We'd like to turn on chrome.storage.sync by default. That means flipping the pref and pointing to the production server.

Then we can let it ride the trains out to production in Firefox 53.

Still waiting on bug 1311510 to be completed before it hits beta.

Need info'ing Ethan and Krupa just to check that's ok with them.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1331467: Enable chrome.storage.sync by default,

Review commit: https://reviewboard.mozilla.org/r/105544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105544/

Comment 2

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4fa9eeb1e9

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Attached please find a patch that should turn on chrome.storage.sync by default.

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8827992 [details]
Bug 1331467: Enable chrome.storage.sync by default,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105544/diff/1-2/

Comment 5

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad819c7358b6

Comment 6

[krupa raj [:krupa--use this to needinfo]]

With the caveat that https://bugzilla.mozilla.org/show_bug.cgi?id=1311510 needs to be complete before the feature hits beta, QA = a+ on this feature. All the test results can be tracked at https://goo.gl/QcGgvH

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8827992 [details]
Bug 1331467: Enable chrome.storage.sync by default,

https://reviewboard.mozilla.org/r/105544/#review107116

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/442d75009799
Enable chrome.storage.sync by default, r=kmag

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for test_ext_storage_content.html failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=70846690&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/68abeaaf3a2e1c4f32e618de595006b4c65a15ca

Comment 10

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8827992 [details]
Bug 1331467: Enable chrome.storage.sync by default,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105544/diff/2-3/

Comment 11

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09223e98b279

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44f4eef0b271
Enable chrome.storage.sync by default, r=kmag

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/44f4eef0b271