1331575 - Explicitly pass lock proofs to TelemetryScalars thread unsafe functions

Status: RESOLVED DUPLICATE of bug 1362957

(Toolkit :: Telemetry, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

TelemetryScalar.cpp is prefixing all thread unsafe functions with the "internal_" prefix [1]. After it landed, we decided to change these functions so that their caller has to provide the proof it owns a lock.

This basically means we should add a |const StaticMutexAutolock&| parameter to each of the previously mentioned function and that the callers have to change to pass the lock as an argument, as done in TelemetryEvents.cpp [2].


[1] - http://searchfox.org/mozilla-central/search?q=internal_&case=false&regexp=false&path=TelemetryScalar.cpp
[2] - http://searchfox.org/mozilla-central/rev/c477aa8bd99278962998adba1c5e4b15a02c42c7/toolkit/components/telemetry/TelemetryEvent.cpp#274

Comment 1

[Alessio Placitelli [:Dexter]]

This was already addressed by a contributor in bug 1362957. Closing this.